From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=209.85.214.172 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794327836; b=S7OG/oBoLT24Q9xIy+pHo5Ngw2hZy3pwUmiatqL0a0buqdzwbzCP8FSuYBkBlavdW25z NC4Q9XI3d28Tl6U2DFeMGPeWFg5KqMCvA+Swby8UlmUzyZvHY6mwcKtGvDsBU9Dsy10JR TtkY+bDOLLLALHa9lseugboSNPJtchWgyo64iH6MmZ+3IAtnusUVVKyfG0uC4PdZIDx8d ha1JtE2Vmx/GLKIV7hxVv9Hj8cedbkTOTUxC878cczY/5VJy1HK/B4RAj4tMX6OEKAout T05IEfMWi7WVlucNDQ2MrQ0e7F9rBxOcU9U41RJh7Et7+ym8IXmf4hQE6pJyaw5cO9A== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794327836; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Gm-Gg:X-Received:Received: Mime-Version:Content-Transfer-Encoding:Content-Type:Date:Message-Id: Cc:Subject:From:To:X-Mailer:References:In-Reply-To; bh=Mw9iOCkEBWkvxdLSgoJVCB6jT3T4ThA8jIPRTFH0lnY=; b=GVyLibGf/j1a7BGW/0O+cib9sWvz8Y9z3J6wbYehWuIP3D0OxE1HIYcfRD5Jy/wDmB/f 22j0WMse/UQFPgpIArDfCl5RhKpx7BnIzU//Ez1zeJLwtlNKp4y+fjmRBIPXYieGh5RCx 9Q4da3/6GBKxOFtWUNW5kQme+VqueGQfXrj7zxwAOyM/UVg/GyA2zIgTSfNG6j/cGP53r zG2R/ZJr7gWG8EtrDIc436CU44iogPoTZyVuErDhJ5VCLAYUdYFLzaBN0fRb9LgAtJvoz x9LRY+fQ3Cv+EaeVi8WSsINhosQ+2IQV4HY6XMzqh6s2HLvehePmRpx2iH5yQyM0Cfg== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20260707 header.b=VSPzJL76; arc=none smtp.remote-ip=209.85.214.172 Received: from mail-pl1-f172.google.com (mail-pl1-f172.google.com [209.85.214.172]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4DBEE606A325 for ; Tue, 10 Nov 2026 16:23:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 4DBEE606A325 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20260707 header.b=VSPzJL76 Received: by mail-pl1-f172.google.com with SMTP id d9443c01a7336-2ea138a3497so14295385ad.2 for ; Tue, 10 Nov 2026 08:23:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20260707; t=1794327836; x=1794932636; darn=vger.kernel.org; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-type:content-transfer-encoding:mime-version:from:to:cc :subject:date:message-id:reply-to:content-type; bh=Mw9iOCkEBWkvxdLSgoJVCB6jT3T4ThA8jIPRTFH0lnY=; b=VSPzJL76+wTF7+tRHaTvgknu/rdXasZus90UA5dew9kegykwMMzKH/F1V6GxO7RQBH 4/OoTFVOHyB4E03Dq2sjac2puiHJm+c4fvoFKJLJ6EEpCLTW90+KxQKP8Xk4x1JCosEq Qn1NC6kr4qdwt4JzE8ObsRxCsUeZmKjtT2SBeeizeKBMIl7bOARS8kw8yLezlhGZJVv0 o52jzOWxsMkIIBT3ThUaLCPi/QAmSZxKSqqb6hMrak99PMeAxD3u0dk/TP7xs21D2Iw/ Ez/eieBRGPY5ouf/XdRZ3e00nlnuno9Ot9UU0ZRzVZtwWy7hL9Ca1MHSbWRqNGS8EsIb 6SQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1794327836; x=1794932636; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-type:content-transfer-encoding:mime-version:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=Mw9iOCkEBWkvxdLSgoJVCB6jT3T4ThA8jIPRTFH0lnY=; b=Ob0uTQE33biRmo7oB18/I7UBgWB5jlsLuD0iI3irXHxBxqAD1SbXpEjIQJ1uFz8tHk KEw26d7iiiV6XVp36xsIwgxfPIsP9TRPfRV3TnWPkcPgGySD4H5vSzASDuxHYVAyRPre G9O4NeaFpf4UcXTp7NtOcpTcxLpQ6l+q5yQBWAsM51nfK6bnbHDpKXvfTnWbFPS9z+yw 1kZXQmtKSZEGgeA3xItbJjr31t578CRCf80JnQFm95URtRWiAuL0yjHgueaIK7VMM0dK hMAT9Yy09j9nEZ6shslwOH1HPZzLmQgTfGrgoBeZt1X2Dcmb6EL644ekrFesqM3VrMbZ bRaw== X-Forwarded-Encrypted: i=1; AL+hErFJ7jAfJE7Qdng+4IXh513ROFbS+WmRjRRSoHPLAg0U2CmJ/XQvwOwAWU3eh+kd8m5itVxJeDmJqJc=@vger.kernel.org X-Gm-Message-State: APuU4Z8aGbVgvEnxLbrI88ugFfFk2mvqB+v2pmr85hd5f82l5p6eIbJ3 EhjW30A8IXLLRg1yCbI3eU30xFVz6HEC0p4Y9gob5yeZ6yMZgM/U6wVvoRlQgQvT8w== X-Gm-Gg: AYBFou3reh0n4HLrYvqGcx4dNfxDs8Mu1TKCS0RFp7CT7I2Uwy3HFdUaxlrLko6mRQt 7e1UuMHOtDpJG9wLHeQDKLq5hx/wfLBzZMSrfx0zpm7R+3U5nI4U2ELGhMu8yzkz50eminoeybi M2Xm7UPAjMAX8eU8EQPEDSDUE8Sc4J+MRq/fZvY4/Fjg9ArrIDzBMhwTr+gtbYOSn+RFwXOzrpU zXsOR8hB8S6EBWefi8GGZWAB65CjRqL+BDbXx6Vzm+XKJqgtmBfYljblNAUYeoJaUUSjqTah20N xOS1JAz526b4tSNakNnmLTACZuYzC0ymQ69uwAh80vilQU6+5SMBva1LH1uVJWVlmzETJYLDPqQ eqqfBk9q17IN0N+lkbzanuZDo7QAwZ09YTkmeRohLJf5OHAGW/jXDSLUBvQaMVL+KOZKWOs7hb0 V9kXDnPvfJJVwmRL2B2mScq4sA2TAjjnnXbZO3JcsmeLUa1ek/miNO9iLoGut7v62Tc+Jsx75KI EJRwvbZaFaDpLrIRDbVf+cqEJ6uxbTnLhcS2Oskje7meEyvIEMS/EUUV3aaMFTsFDLCMLazb2xa 1lpwv4VGSIF365ZHS+2+SzOCGhZvWswml0C7SzUOKaF4Wjlw/7gFI1IlX5J8wUmU X-Received: by 2002:a17:902:d4cc:b0:2e8:18ca:5f46 with SMTP id d9443c01a7336-2edb9146ba8mr28990585ad.14.1794327834955; Tue, 10 Nov 2026 08:23:54 -0800 (PST) Received: from localhost (33.79.127.34.bc.googleusercontent.com. [34.127.79.33]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2edb6d7d964sm11306915ad.32.2026.11.10.08.23.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 10 Nov 2026 08:23:54 -0800 (PST) X-Mailing-List: linux-pci@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Tue, 10 Nov 2026 16:23:53 +0000 Message-Id: Cc: , , "Pratyush Yadav" , , , , , , , , , Subject: Re: [PATCH v4 16/19] PCI: liveupdate: Add feature header to struct pci_dev_ser From: "David Matlack" To: "Tarun Sahu" , "Pasha Tatashin" , "Mike Rapoport" , , , , "David Matlack" , "Alexander Graf" , , , , , , , "Bjorn Helgaas" , , , , , "Andrew Morton" , , X-Mailer: aerc 0.21.0 References: <20261110050202.529473-1-tarunsahu@google.com> <20261110050202.529473-17-tarunsahu@google.com> In-Reply-To: <20261110050202.529473-17-tarunsahu@google.com> On Tue Nov 10, 2026 at 5:01 AM UTC, Tarun Sahu wrote: > Precede each serialized PCI device entry in the PCI Live Update KHO block > set with struct kho_ser_hdr via DECLARE_KHO_SER so future per-device PCI > Live Update features can append fields to struct pci_dev_ser without > breaking compatibility between adjacent kernels. Elements of a collection should not have their own feature headers. This applies to patches 10, 12, 14, 16 and 18. I raised this during the v2 discussion [1][2], but I don't think it was addressed. All entries in a KHO block set are written by the same kernel using the same struct, and the block set has a single entry_size, so every entry header is necessarily identical. They don't convey anything that the header of the struct that owns the collection can't. In this case, struct pci_ser's header can define features that describe fields in struct pci_dev_ser, and the PCI core checks them once before iterating. If a feature only applies to some devices, the field's value in each entry says whether that device uses it. Per-entry headers also cost a lot for small entries. struct pci_dev_ser goes from 8 to 16 bytes, and to 24 bytes once the first feature is added. Patch 18 does the same for every preserved memfd folio, which for a large guest backed by 4K pages adds gigabytes of preserved metadata. They also add new ways to read out of bounds. kho_ser_payload() trusts nr_required/nr_optional in each entry, and nothing checks that the entry header plus payload fit within entry_size. In patches 14 and 18 the walk uses each entry's fhdr->size to find the next entry, so one bad header throws off every entry after it. Instead I would keep struct pci_dev_ser as a plain struct, take the entry size from the KHO block header (patch 2), and in pci_flb_retrieve() check once that the entry size covers the base fields, plus the fields of any features set in struct pci_ser's header, e.g.: entry_size =3D kho_block_set_entry_size(&incoming->block_set); if (entry_size < offsetofend(struct pci_dev_ser, refcount)) panic(...); That also restores the minimum entry size check that the v10 PCI series had with PCI_DEV_SER_MIN_SIZE, which this version drops. [...] > - kho_block_set_init(&incoming->block_set, sizeof(struct pci_dev_ser)); > + kho_block_set_init(&incoming->block_set, kho_ser_size(pci_dev_ser)); This size is never used. kho_block_set_restore() overwrites it with the entry size recorded by the previous kernel. Passing this kernel's size here is misleading: pci_flb_retrieve() (and the LUO session/file restore paths) read as if they iterate incoming entries with the outgoing entry size, which would be a bug. Incoming block sets should not take an entry size at all. kho_block_set_restore() should initialize the block set itself from the incoming block headers, and the incoming paths should drop the kho_block_set_init() call. [1] https://lore.kernel.org/kexec/atl6K2Juy6Bh29lh@google.com/ [2] https://lore.kernel.org/kexec/at-8vkVpN2SF3XgB@google.com/