From: "Danilo Krummrich" <dakr@kernel.org>
To: "Gary Guo" <gary@garyguo.net>
Cc: <gregkh@linuxfoundation.org>, <rafael@kernel.org>,
<johan@kernel.org>, <david.m.ertman@intel.com>,
<iweiny@kernel.org>, <leon@kernel.org>, <ojeda@kernel.org>,
<boqun@kernel.org>, <bjorn3_gh@protonmail.com>,
<lossin@kernel.org>, <a.hindborg@kernel.org>,
<aliceryhl@google.com>, <tmgross@umich.edu>,
<daniel.almeida@collabora.com>, <tamird@kernel.org>,
<acourbot@nvidia.com>, <work@onurozkan.dev>,
<igor.korotin@linux.dev>, <bhelgaas@google.com>,
<kwilczynski@kernel.org>, <markus.probst@posteo.de>,
<driver-core@lists.linux.dev>, <rust-for-linux@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <linux-pci@vger.kernel.org>,
<linux-serial@vger.kernel.org>, <linux-usb@vger.kernel.org>
Subject: Re: [PATCH 0/7] rust: treewide: remove driver unbind callbacks
Date: Thu, 12 Nov 2026 15:37:10 +0100 [thread overview]
Message-ID: <DMTB44YUT8RP.1TL0XPUEC4H6J@kernel.org> (raw)
In-Reply-To: <DMT4Y6N50BGG.3IEM84MO461ZY@garyguo.net>
On Thu Nov 12, 2026 at 10:47 AM CET, Gary Guo wrote:
> On Thu Nov 12, 2026 at 12:52 AM GMT, Danilo Krummrich wrote:
>> The driver model uses native Rust lifetimes, allowing driver data to
>> retain device resources and a bound device reference for use in its
>> destructor. Separate teardown callbacks are therefore no longer needed.
>>
>> Remove unbind() from the PCI, platform, auxiliary, serdev and I2C driver
>> traits, and disconnect() from the USB driver trait. Move the affected
>> sample teardown into destructors and update the driver documentation.
>
> unbind() has the `Device<Core>` state, which the destructor won't be able to
> get. Are we sure we won't need it in the future?
Yeah, unbind() was only ever meant to provide a Device<Bound>, so drivers could
access device resources (such as I/O memory) to communicate with the device for
teardown.
prev parent reply other threads:[~2026-11-12 14:37 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-12 0:52 [PATCH 0/7] rust: treewide: remove driver unbind callbacks Danilo Krummrich
2026-11-12 0:52 ` [PATCH 1/7] rust: pci: remove the unbind() callback Danilo Krummrich
2026-11-12 1:19 ` sashiko-bot
2026-11-12 0:52 ` [PATCH 2/7] rust: platform: " Danilo Krummrich
2026-11-12 1:07 ` sashiko-bot
2026-11-12 0:52 ` [PATCH 3/7] rust: auxiliary: " Danilo Krummrich
2026-11-12 1:05 ` sashiko-bot
2026-11-12 0:52 ` [PATCH 4/7] rust: serdev: " Danilo Krummrich
2026-11-12 1:47 ` sashiko-bot
2026-11-12 0:52 ` [PATCH 5/7] rust: i2c: " Danilo Krummrich
2026-11-12 1:19 ` sashiko-bot
2026-11-12 0:53 ` [PATCH 6/7] rust: usb: remove the disconnect() callback Danilo Krummrich
2026-11-12 1:50 ` sashiko-bot
2026-11-12 0:53 ` [PATCH 7/7] rust: driver: document teardown through destructors Danilo Krummrich
2026-11-12 1:08 ` sashiko-bot
2026-11-12 9:47 ` [PATCH 0/7] rust: treewide: remove driver unbind callbacks Gary Guo
2026-11-12 14:37 ` Danilo Krummrich [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DMTB44YUT8RP.1TL0XPUEC4H6J@kernel.org \
--to=dakr@kernel.org \
--cc=a.hindborg@kernel.org \
--cc=acourbot@nvidia.com \
--cc=aliceryhl@google.com \
--cc=bhelgaas@google.com \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun@kernel.org \
--cc=daniel.almeida@collabora.com \
--cc=david.m.ertman@intel.com \
--cc=driver-core@lists.linux.dev \
--cc=gary@garyguo.net \
--cc=gregkh@linuxfoundation.org \
--cc=igor.korotin@linux.dev \
--cc=iweiny@kernel.org \
--cc=johan@kernel.org \
--cc=kwilczynski@kernel.org \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=lossin@kernel.org \
--cc=markus.probst@posteo.de \
--cc=ojeda@kernel.org \
--cc=rafael@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=tamird@kernel.org \
--cc=tmgross@umich.edu \
--cc=work@onurozkan.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox