Re: [PATCH v3 0/3] PCI/MSI: Cleanup init and improve 32-bit MSI checking

Bjorn Helgaas
2020-12-04T18:22:22Z

On Thu, Dec 03, 2020 at 12:51:07PM -0600, Bjorn Helgaas wrote:
> From: Bjorn Helgaas <bhelgaas@google.com>
>
> MSI/MSI-X init was a little unconventional. We had pci_msi_setup_pci_dev()
> to disable MSI and MSI-X, in probe.c instead of msi.c so we could do it
> even without CONFIG_PCI_MSI. Move that to msi.c and fix the config issue
> with an #ifdef.
>
> Then add Vidya's patch on top. Previous postings at
>
> https://lore.kernel.org/linux-pci/20201117145728.4516-1-vidyas@nvidia.com/
> https://lore.kernel.org/linux-pci/20201124105035.24573-1-vidyas@nvidia.com/
>
> Bjorn Helgaas (2):
> PCI/MSI: Move MSI/MSI-X init to msi.c
> PCI/MSI: Move MSI/MSI-X flags updaters to msi.c
>
> Vidya Sagar (1):
> PCI/MSI: Set device flag indicating only 32-bit MSI support
>
> drivers/pci/Makefile | 3 +-
> drivers/pci/msi.c | 70 ++++++++++++++++++++++++++++++++++++++++----
> drivers/pci/pci.h | 23 ++-------------
> drivers/pci/probe.c | 21 ++-----------
> 4 files changed, 70 insertions(+), 47 deletions(-)

I fixed my typo ("#ifdef CONFIG_MSI" when it should have been
"#ifdef CONFIG_PCI_MSI"), added the reference from Vidya, added
Thierry's Reviewed-by, and put these on pci/msi for v5.11.