From: "Krzysztof Wilczyński" <kw@linux.com>
To: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Cc: bhelgaas@google.com, linux-pci@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
steev@kali.org
Subject: Re: [PATCH] PCI: pciehp: Add Qualcomm quirk for Command Completed erratum
Date: Tue, 14 Feb 2023 06:07:37 +0900 [thread overview]
Message-ID: <Y+qmmY+At4eFg1Dq@rocinante> (raw)
In-Reply-To: <20230213144922.89982-1-manivannan.sadhasivam@linaro.org>
Hello,
> The Qualcomm PCI bridge device (Device ID 0x010e) found in chipsets such as
> SC8280XP used in Lenovo Thinkpad X13s, does not set the Command Completed
> bit unless writes to the Slot Command register change "Control" bits.
>
> This results in timeouts like below during boot and resume from suspend:
>
> pcieport 0002:00:00.0: pciehp: Timeout on hotplug command 0x03c0 (issued 2020 msec ago)
> ...
> pcieport 0002:00:00.0: pciehp: Timeout on hotplug command 0x13f1 (issued 107724 msec ago)
>
> Add the device to the Command Completed quirk to mark commands "completed"
> immediately unless they change the "Control" bits.
>
> Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Applied to pci/hotplug, thank you!
[1/1] PCI: pciehp: Add Qualcomm quirk for Command Completed erratum
https://git.kernel.org/pci/pci/c/dc4e71ddbe8e
Krzysztof
prev parent reply other threads:[~2023-02-13 21:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-13 14:49 [PATCH] PCI: pciehp: Add Qualcomm quirk for Command Completed erratum Manivannan Sadhasivam
2023-02-13 21:01 ` Bjorn Helgaas
2023-02-13 21:07 ` Krzysztof Wilczyński [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y+qmmY+At4eFg1Dq@rocinante \
--to=kw@linux.com \
--cc=bhelgaas@google.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=steev@kali.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox