From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6506CC636D4 for ; Wed, 15 Feb 2023 11:34:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232212AbjBOLem (ORCPT ); Wed, 15 Feb 2023 06:34:42 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38198 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233329AbjBOLei (ORCPT ); Wed, 15 Feb 2023 06:34:38 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1AE593802B for ; Wed, 15 Feb 2023 03:34:23 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 6F395B820F6 for ; Wed, 15 Feb 2023 11:34:20 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8194AC433EF; Wed, 15 Feb 2023 11:34:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1676460859; bh=p2gAL4ilpMp+BiXY2ZsuutTuD7TjaYqVjypXKpj9MYk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=k8uLO52QLjj3T+vkidJdLmTI47VHOUf3M+NTMwIaKGkhxOXeO0m9bdRsBOq+tljSb yWUnSJU3zgvdcP4lyLXS6sMM8r8v75AAq/1ePqsW9dZIWQrLbpWPZRiGOgkVZEPtbN AN3HgJRUnoAcVtlu7EzEjdyap4TpMXAJB/Ja2+0k= Date: Wed, 15 Feb 2023 12:34:16 +0100 From: Greg Kroah-Hartman To: Damien Le Moal Cc: Bjorn Helgaas , linux-pci@vger.kernel.org, Rick Wertenbroek , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Manivannan Sadhasivam , Kishon Vijay Abraham I , Arnd Bergmann Subject: Re: [PATCH 07/12] pci: epf-test: Add debug and error messages Message-ID: References: <20230215032155.74993-1-damien.lemoal@opensource.wdc.com> <20230215032155.74993-8-damien.lemoal@opensource.wdc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230215032155.74993-8-damien.lemoal@opensource.wdc.com> Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On Wed, Feb 15, 2023 at 12:21:50PM +0900, Damien Le Moal wrote: > Make the pci-epf-test driver more verbose with dynamic debug messages > using dev_dbg(). Also add some dev_err() error messages to help > troubleshoot issues. > > Signed-off-by: Damien Le Moal > --- > drivers/pci/endpoint/functions/pci-epf-test.c | 69 +++++++++++++++---- > 1 file changed, 56 insertions(+), 13 deletions(-) > > diff --git a/drivers/pci/endpoint/functions/pci-epf-test.c b/drivers/pci/endpoint/functions/pci-epf-test.c > index f630393e8208..9b791f4a7ffb 100644 > --- a/drivers/pci/endpoint/functions/pci-epf-test.c > +++ b/drivers/pci/endpoint/functions/pci-epf-test.c > @@ -330,6 +330,10 @@ static int pci_epf_test_copy(struct pci_epf_test *epf_test, bool use_dma) > enum pci_barno test_reg_bar = epf_test->test_reg_bar; > volatile struct pci_epf_test_reg *reg = epf_test->reg[test_reg_bar]; > > + dev_dbg(&epf->dev, > + "COPY src addr 0x%llx, dst addr 0x%llx, %u B\n", > + reg->src_addr, reg->dst_addr, reg->size); Again, no, please just use ftrace. thanks, greg k-h