From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 63F88C4332F for ; Mon, 17 Oct 2022 07:44:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230221AbiJQHoq (ORCPT ); Mon, 17 Oct 2022 03:44:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40290 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230102AbiJQHop (ORCPT ); Mon, 17 Oct 2022 03:44:45 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0AC171EC61; Mon, 17 Oct 2022 00:44:44 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 8E2D260F68; Mon, 17 Oct 2022 07:44:43 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 67137C433D7; Mon, 17 Oct 2022 07:44:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1665992683; bh=762l0StSz/K7tU5EDi5x7CTZNdEOP6u673sfhPq8Obg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=d2Q+UQLuzVLVgjbv7NgmM1ahBDHgvOcAoa4jED6v3iWUKhJrY9T/sdvoP5YDKTFWg TlIc0EdyCI73QPOvlCrR+GSRgtje7fTLng01LLj8HoHImcQTYXzrrPkpStX80aZbHY liK+NVaV5KiRgRVFmAlFV8b8or3fGEONsj1K8L28vIHvFPLA70p6ukY+GOUI0p5lbF ppVJA9PjPnGLl3bHGo+C5ikiwIF3U924NaXIHVMVDf+qw2jZIf0vgF3Hbf2I0078lI ii/z7X4Y8XYmpXdA5ysyzAzz1zFXe0AVuxShoBMCKXo/woQYFZoevRIdk2/EBNW+XL UI3YnOkawfCZw== Date: Mon, 17 Oct 2022 13:14:38 +0530 From: Vinod Koul To: Dmitry Baryshkov Cc: Andy Gross , Bjorn Andersson , Konrad Dybcio , Rob Herring , Jingoo Han , Gustavo Pimentel , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Bjorn Helgaas , Kishon Vijay Abraham I , Philipp Zabel , Johan Hovold , linux-arm-msm@vger.kernel.org, linux-pci@vger.kernel.org, linux-phy@lists.infradead.org Subject: Re: [PATCH v6 0/5] PCI: qcom: Support using the same PHY for both RC and EP Message-ID: References: <20220927092207.161501-1-dmitry.baryshkov@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220927092207.161501-1-dmitry.baryshkov@linaro.org> Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On 27-09-22, 12:22, Dmitry Baryshkov wrote: > Programming of QMP PCIe PHYs slightly differs between RC and EP modes. > > Currently both qcom and qcom-ep PCIe controllers setup the PHY in the > default mode, making it impossible to select at runtime whether the PHY > should be running in RC or in EP modes. Usually this is not an issue, > since for most devices only the RC mode is used. Some devices (SDX55) > currently support only the EP mode without supporting the RC mode (at > this moment). > > Nevertheless some of the Qualcomm platforms (e.g. the aforementioned > SDX55) would still benefit from being able to switch between RC and EP > depending on the driver being used. While it is possible to use > different compat strings for the PHY depending on the mode, it seems > like an incorrect approach, since the PHY doesn't differ between > usecases. It's the PCIe controller, who should decide how to configure > the PHY. > > This patch series implements the ability to select between RC and EP > modes, by allowing the PCIe QMP PHY driver to switch between > programming tables. > > This patchseries depends on the header from the pre-6.1 phy/next. Thus > after the 6.1 the PCIe patches can be applied independently of the PHY > part. Applied, thanks -- ~Vinod