From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-pci-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 671CDC4332F
	for <linux-pci@archiver.kernel.org>; Tue, 15 Nov 2022 10:27:55 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S238007AbiKOK1w (ORCPT <rfc822;linux-pci@archiver.kernel.org>);
        Tue, 15 Nov 2022 05:27:52 -0500
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43704 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S238332AbiKOK1f (ORCPT
        <rfc822;linux-pci@vger.kernel.org>); Tue, 15 Nov 2022 05:27:35 -0500
Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ED28D1F9F3;
        Tue, 15 Nov 2022 02:27:33 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
        d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version
        :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:
        Content-Transfer-Encoding:Content-ID:Content-Description;
        bh=7rjjuG4MhWSWvJIH4DsOcCy+1gVkrN814g410rEgjz4=; b=enAVznMCK/RCROvdDARJDbzBoz
        kxDyIP8h+D6lJx4lvrfd1axgekqzg56kfgGA3FBr2JNukrRzzYqXfIoJzkTZS9ysKlb+dRG62pXVk
        q1LBFTTNn9OdUjgIYHvn0Lwj0mI3ssiYn+UNIpmyYcWgh9K/n8DygdqXz9QyTPWp/E5fhu9O8xbGH
        tpnjBteP1e0swrboXUYztS4CNT4M2Y4xHGGRBtimRtIrgStskNKBVUzgOOsOsJw2MVk7NqA09ZAym
        i6L0euegCdnwQcr1t6wA7l3tSBghwV69XBcegSuB4aYAe49nOdJhjr0VKbkbywkU72XNCdl0UEeCo
        gCY0PrOw==;
Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux))
        id 1outA5-009ugK-OR; Tue, 15 Nov 2022 10:27:25 +0000
Date:   Tue, 15 Nov 2022 02:27:25 -0800
From:   Christoph Hellwig <hch@infradead.org>
To:     Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Cc:     nirmal.patel@linux.intel.com, jonathan.derrick@linux.dev,
        lpieralisi@kernel.org, robh@kernel.org, kw@linux.com,
        bhelgaas@google.com, linux-pci@vger.kernel.org,
        linux-kernel@vger.kernel.org, Abaci Robot <abaci@linux.alibaba.com>
Subject: Re: [PATCH] PCI: vmd: Clean up some inconsistent indenting
Message-ID: <Y3NpjbXkcb3wfZcQ@infradead.org>
References: <20221115054847.77829-1-jiapeng.chong@linux.alibaba.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20221115054847.77829-1-jiapeng.chong@linux.alibaba.com>
X-SRS-Rewrite: SMTP reverse-path rewritten from <hch@infradead.org> by bombadil.infradead.org. See http://www.infradead.org/rpr.html
Precedence: bulk
List-ID: <linux-pci.vger.kernel.org>
X-Mailing-List: linux-pci@vger.kernel.org

On Tue, Nov 15, 2022 at 01:48:47PM +0800, Jiapeng Chong wrote:
> +	if (vmd->irq_domain)
> +		vmd_set_msi_remapping(vmd, true);
> +	else
> +		vmd_set_msi_remapping(vmd, false);

Why not go one step further:

	vmd_set_msi_remapping(vmd, !!vmd->irq_domain);

?