From: "Krzysztof Wilczyński" <kw@linux.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>,
nirmal.patel@linux.intel.com, jonathan.derrick@linux.dev,
lpieralisi@kernel.org, robh@kernel.org, bhelgaas@google.com,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
Abaci Robot <abaci@linux.alibaba.com>
Subject: Re: [PATCH] PCI: vmd: Clean up some inconsistent indenting
Date: Wed, 16 Nov 2022 12:47:19 +0900 [thread overview]
Message-ID: <Y3RdR+9QSVPWyae3@rocinante> (raw)
In-Reply-To: <Y3NpjbXkcb3wfZcQ@infradead.org>
Hello,
> > + if (vmd->irq_domain)
> > + vmd_set_msi_remapping(vmd, true);
> > + else
> > + vmd_set_msi_remapping(vmd, false);
>
> Why not go one step further:
>
> vmd_set_msi_remapping(vmd, !!vmd->irq_domain);
Jiapeng, if you want to get this patch merged, and it's a nice clean-up,
then apply suggestion from Christoph and send a v2, if possible.
Krzysztof
next prev parent reply other threads:[~2022-11-16 3:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-15 5:48 [PATCH] PCI: vmd: Clean up some inconsistent indenting Jiapeng Chong
2022-11-15 10:27 ` Christoph Hellwig
2022-11-16 3:47 ` Krzysztof Wilczyński [this message]
2022-11-16 0:44 ` Patel, Nirmal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y3RdR+9QSVPWyae3@rocinante \
--to=kw@linux.com \
--cc=abaci@linux.alibaba.com \
--cc=bhelgaas@google.com \
--cc=hch@infradead.org \
--cc=jiapeng.chong@linux.alibaba.com \
--cc=jonathan.derrick@linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=nirmal.patel@linux.intel.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).