* [PATCH] PCI: vmd: Clean up some inconsistent indenting
@ 2022-11-15 5:48 Jiapeng Chong
2022-11-15 10:27 ` Christoph Hellwig
2022-11-16 0:44 ` Patel, Nirmal
0 siblings, 2 replies; 4+ messages in thread
From: Jiapeng Chong @ 2022-11-15 5:48 UTC (permalink / raw)
To: nirmal.patel
Cc: jonathan.derrick, lpieralisi, robh, kw, bhelgaas, linux-pci,
linux-kernel, Jiapeng Chong, Abaci Robot
No functional modification involved.
drivers/pci/controller/vmd.c:983 vmd_resume() warn: inconsistent indenting.
Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3074
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
drivers/pci/controller/vmd.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/pci/controller/vmd.c b/drivers/pci/controller/vmd.c
index 98e0746e681c..b7914637048a 100644
--- a/drivers/pci/controller/vmd.c
+++ b/drivers/pci/controller/vmd.c
@@ -980,10 +980,10 @@ static int vmd_resume(struct device *dev)
struct vmd_dev *vmd = pci_get_drvdata(pdev);
int err, i;
- if (vmd->irq_domain)
- vmd_set_msi_remapping(vmd, true);
- else
- vmd_set_msi_remapping(vmd, false);
+ if (vmd->irq_domain)
+ vmd_set_msi_remapping(vmd, true);
+ else
+ vmd_set_msi_remapping(vmd, false);
for (i = 0; i < vmd->msix_count; i++) {
err = devm_request_irq(dev, vmd->irqs[i].virq,
--
2.20.1.7.g153144c
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] PCI: vmd: Clean up some inconsistent indenting
2022-11-15 5:48 [PATCH] PCI: vmd: Clean up some inconsistent indenting Jiapeng Chong
@ 2022-11-15 10:27 ` Christoph Hellwig
2022-11-16 3:47 ` Krzysztof Wilczyński
2022-11-16 0:44 ` Patel, Nirmal
1 sibling, 1 reply; 4+ messages in thread
From: Christoph Hellwig @ 2022-11-15 10:27 UTC (permalink / raw)
To: Jiapeng Chong
Cc: nirmal.patel, jonathan.derrick, lpieralisi, robh, kw, bhelgaas,
linux-pci, linux-kernel, Abaci Robot
On Tue, Nov 15, 2022 at 01:48:47PM +0800, Jiapeng Chong wrote:
> + if (vmd->irq_domain)
> + vmd_set_msi_remapping(vmd, true);
> + else
> + vmd_set_msi_remapping(vmd, false);
Why not go one step further:
vmd_set_msi_remapping(vmd, !!vmd->irq_domain);
?
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] PCI: vmd: Clean up some inconsistent indenting
2022-11-15 5:48 [PATCH] PCI: vmd: Clean up some inconsistent indenting Jiapeng Chong
2022-11-15 10:27 ` Christoph Hellwig
@ 2022-11-16 0:44 ` Patel, Nirmal
1 sibling, 0 replies; 4+ messages in thread
From: Patel, Nirmal @ 2022-11-16 0:44 UTC (permalink / raw)
To: Jiapeng Chong
Cc: jonathan.derrick, lpieralisi, robh, kw, bhelgaas, linux-pci,
linux-kernel, Abaci Robot
On 11/14/2022 9:48 PM, Jiapeng Chong wrote:
> No functional modification involved.
>
> drivers/pci/controller/vmd.c:983 vmd_resume() warn: inconsistent indenting.
>
> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3074
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
> ---
> drivers/pci/controller/vmd.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/pci/controller/vmd.c b/drivers/pci/controller/vmd.c
> index 98e0746e681c..b7914637048a 100644
> --- a/drivers/pci/controller/vmd.c
> +++ b/drivers/pci/controller/vmd.c
> @@ -980,10 +980,10 @@ static int vmd_resume(struct device *dev)
> struct vmd_dev *vmd = pci_get_drvdata(pdev);
> int err, i;
>
> - if (vmd->irq_domain)
> - vmd_set_msi_remapping(vmd, true);
> - else
> - vmd_set_msi_remapping(vmd, false);
> + if (vmd->irq_domain)
> + vmd_set_msi_remapping(vmd, true);
> + else
> + vmd_set_msi_remapping(vmd, false);
>
> for (i = 0; i < vmd->msix_count; i++) {
> err = devm_request_irq(dev, vmd->irqs[i].virq,
Reviewed-by: Nirmal Patel <nirmal.patel@linux.intel.com>
Thanks
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] PCI: vmd: Clean up some inconsistent indenting
2022-11-15 10:27 ` Christoph Hellwig
@ 2022-11-16 3:47 ` Krzysztof Wilczyński
0 siblings, 0 replies; 4+ messages in thread
From: Krzysztof Wilczyński @ 2022-11-16 3:47 UTC (permalink / raw)
To: Christoph Hellwig
Cc: Jiapeng Chong, nirmal.patel, jonathan.derrick, lpieralisi, robh,
bhelgaas, linux-pci, linux-kernel, Abaci Robot
Hello,
> > + if (vmd->irq_domain)
> > + vmd_set_msi_remapping(vmd, true);
> > + else
> > + vmd_set_msi_remapping(vmd, false);
>
> Why not go one step further:
>
> vmd_set_msi_remapping(vmd, !!vmd->irq_domain);
Jiapeng, if you want to get this patch merged, and it's a nice clean-up,
then apply suggestion from Christoph and send a v2, if possible.
Krzysztof
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-11-16 3:47 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-11-15 5:48 [PATCH] PCI: vmd: Clean up some inconsistent indenting Jiapeng Chong
2022-11-15 10:27 ` Christoph Hellwig
2022-11-16 3:47 ` Krzysztof Wilczyński
2022-11-16 0:44 ` Patel, Nirmal
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).