From: "Krzysztof Wilczyński" <kw@linux.com>
To: "Alexey V. Vissarionov" <gremlin@altlinux.org>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
Alex Williamson <alex.williamson@redhat.com>,
Jesse Barnes <jbarnes@virtuousgeek.org>,
Matthew Wilcox <willy@infradead.org>, Yu Zhao <yu.zhao@intel.com>,
linux-pci@vger.kernel.org, lvc-project@linuxtesting.org
Subject: Re: [PATCH] PCI/IOV: "virtfn4294967295\0" requires 17 bytes
Date: Sun, 18 Dec 2022 19:57:02 +0900 [thread overview]
Message-ID: <Y57x/iCSkdtU3kov@rocinante> (raw)
In-Reply-To: <20221218033347.23743-1-gremlin@altlinux.org>
(CC Alex directly for visibility)
Hi Alexey,
Thank you for sending the patch over! However, if possible, can you send
it as plain text without any multi-part MIME involved? This is as per:
https://www.kernel.org/doc/html/latest/process/submitting-patches.html
People have scripts to handle patches submissions, plus there is automation
that relies on e-mails being just plain text with inline patches.
Sorry for the trouble, and thank you for understanding.
> Although unlikely, the 'id' value may be as big as 4294967295
> (uint32_max) and "virtfn4294967295\0" would require 17 bytes
> instead of 16.
If possible, it would be nice to mention that this needed to make sure
that there is enough space to correctly NULL-terminate the ID string.
Thank you!
Krzysztof
next prev parent reply other threads:[~2022-12-18 10:57 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-18 3:33 [PATCH] PCI/IOV: "virtfn4294967295\0" requires 17 bytes Alexey V. Vissarionov
2022-12-18 10:57 ` Krzysztof Wilczyński [this message]
2022-12-18 12:21 ` Alexey V. Vissarionov
2022-12-18 22:19 ` Matthew Wilcox
2022-12-18 23:24 ` Alexey V. Vissarionov
2022-12-19 10:16 ` Niklas Schnelle
2022-12-29 18:12 ` Bjorn Helgaas
2022-12-29 21:09 ` Matthew Wilcox
2023-01-12 23:00 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y57x/iCSkdtU3kov@rocinante \
--to=kw@linux.com \
--cc=alex.williamson@redhat.com \
--cc=bhelgaas@google.com \
--cc=gremlin@altlinux.org \
--cc=jbarnes@virtuousgeek.org \
--cc=linux-pci@vger.kernel.org \
--cc=lvc-project@linuxtesting.org \
--cc=willy@infradead.org \
--cc=yu.zhao@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).