From: Johan Hovold <johan@kernel.org>
To: Lorenzo Pieralisi <lpieralisi@kernel.org>
Cc: "Dmitry Baryshkov" <dmitry.baryshkov@linaro.org>,
"Andy Gross" <agross@kernel.org>,
"Bjorn Andersson" <andersson@kernel.org>,
"Konrad Dybcio" <konrad.dybcio@somainline.org>,
"Rob Herring" <robh+dt@kernel.org>,
"Jingoo Han" <jingoohan1@gmail.com>,
"Gustavo Pimentel" <gustavo.pimentel@synopsys.com>,
"Lorenzo Pieralisi" <lorenzo.pieralisi@arm.com>,
"Krzysztof Wilczyński" <kw@linux.com>,
"Bjorn Helgaas" <bhelgaas@google.com>,
linux-arm-msm@vger.kernel.org, linux-pci@vger.kernel.org
Subject: Re: [PATCH 2/4] PCI: qcom: Use clk_bulk_ API for 1.0.0 clocks handling
Date: Mon, 16 Jan 2023 12:26:07 +0100 [thread overview]
Message-ID: <Y8U0T4YVUhe/4hRv@hovoldconsulting.com> (raw)
In-Reply-To: <Y8F+sSf3yG1mLhJo@lpieralisi>
On Fri, Jan 13, 2023 at 04:54:25PM +0100, Lorenzo Pieralisi wrote:
> On Thu, Oct 20, 2022 at 02:22:47PM +0300, Dmitry Baryshkov wrote:
> > On 20/10/2022 14:08, Johan Hovold wrote:
> > > On Thu, Oct 20, 2022 at 01:31:18PM +0300, Dmitry Baryshkov wrote:
> > > > Change hand-coded implementation of bulk clocks to use the existing
> > >
> > > Let's hope everything is "hand-coded" at least for a few years still
> > > (job security). ;)
> > >
> > > Perhaps rephrase using "open-coded"?
> >
> > Yes, thank you.
>
> If that's the only change required I can fix it up when merging the
> series.
I believe there was also a couple of bugs in patch 3/4 which was spotted
by Jingoo Han and that would need to be fixed:
https://lore.kernel.org/all/CAPOBaE5Zg+r0F35MvKWAozFa9x4xvym1LbA_UHvUSmnLbTpqzA@mail.gmail.com/
Johan
next prev parent reply other threads:[~2023-01-16 11:25 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-20 10:31 [PATCH 0/4] PCI: qcom: use clk_bulk API Dmitry Baryshkov
2022-10-20 10:31 ` [PATCH 1/4] PCI: qcom: Move 2_1_0 defines close to the struct definition Dmitry Baryshkov
2022-10-20 10:31 ` [PATCH 2/4] PCI: qcom: Use clk_bulk_ API for 1.0.0 clocks handling Dmitry Baryshkov
2022-10-20 11:08 ` Johan Hovold
2022-10-20 11:22 ` Dmitry Baryshkov
2022-10-20 11:32 ` Johan Hovold
2022-10-20 11:45 ` Dmitry Baryshkov
2023-01-13 15:54 ` Lorenzo Pieralisi
2023-01-16 11:26 ` Johan Hovold [this message]
2022-10-20 10:31 ` [PATCH 3/4] PCI: qcom: Use clk_bulk_ API for 2.3.2 " Dmitry Baryshkov
2022-10-23 23:27 ` Han Jingoo
2022-10-20 10:31 ` [PATCH 4/4] PCI: qcom: Use clk_bulk_ API for 2.3.3 " Dmitry Baryshkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y8U0T4YVUhe/4hRv@hovoldconsulting.com \
--to=johan@kernel.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=bhelgaas@google.com \
--cc=dmitry.baryshkov@linaro.org \
--cc=gustavo.pimentel@synopsys.com \
--cc=jingoohan1@gmail.com \
--cc=konrad.dybcio@somainline.org \
--cc=kw@linux.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=lpieralisi@kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox