Linux PCI subsystem development
 help / color / mirror / Atom feed
From: "Krzysztof Wilczyński" <kw@linux.com>
To: yangerkun <yangerkun@huawei.com>
Cc: toan@os.amperecomputing.com, lorenzo.pieralisi@arm.com,
	robh@kernel.org, bhelgaas@google.com, linux-pci@vger.kernel.org,
	yukuai3@huawei.com
Subject: Re: [PATCH] PCI: xgene-msi: Remove redundant dev_err call in xgene_msi_probe()
Date: Thu, 8 Apr 2021 15:02:28 +0200	[thread overview]
Message-ID: <YG7+5M11XXIlWFFU@rocinante> (raw)
In-Reply-To: <20210408124745.1108948-1-yangerkun@huawei.com>

Hi,

[...]
> There is a error message within devm_ioremap_resource
> already, so remove the dev_err call to avoid redundant
> error message.

Just to add, the devm_ioremap_resource() internally calls
__devm_ioremap_resource() which is where error checking
and handling is actually having place.

> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Erkun Yang<yangerkun@huawei.com>

A space is missing just before the e-mail port of the
"Signed-off-by", you might need to correct this.

Otherwise,

Reviewed-by: Krzysztof Wilczyński <kw@linux.com>

Krzysztof

      reply	other threads:[~2021-04-08 13:02 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-08 12:47 [PATCH] PCI: xgene-msi: Remove redundant dev_err call in xgene_msi_probe() yangerkun
2021-04-08 13:02 ` Krzysztof Wilczyński [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YG7+5M11XXIlWFFU@rocinante \
    --to=kw@linux.com \
    --cc=bhelgaas@google.com \
    --cc=linux-pci@vger.kernel.org \
    --cc=lorenzo.pieralisi@arm.com \
    --cc=robh@kernel.org \
    --cc=toan@os.amperecomputing.com \
    --cc=yangerkun@huawei.com \
    --cc=yukuai3@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox