From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9DEF8C433B4 for ; Wed, 21 Apr 2021 16:54:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 64CB961456 for ; Wed, 21 Apr 2021 16:54:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234323AbhDUQy7 (ORCPT ); Wed, 21 Apr 2021 12:54:59 -0400 Received: from mail-ed1-f49.google.com ([209.85.208.49]:42723 "EHLO mail-ed1-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236426AbhDUQy6 (ORCPT ); Wed, 21 Apr 2021 12:54:58 -0400 Received: by mail-ed1-f49.google.com with SMTP id d21so30083378edv.9; Wed, 21 Apr 2021 09:54:23 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=LwXhMkGUMNYwRKRStEL04Gs6Tphs7NzMu5XYeJimgo8=; b=uJRhbTSULmzlqgrkJy4ph5/So8zPjpSW1EeMWWLxvbYDZ+E50W9Dfl+Dve3OOOJeXy hX3T3RofsHTvSrKKL74SmThBZ7zmY7p/jcyYX8pQmei4R4fRk9lQ1Rzto1FDjddZyxSU WMnltyNR/VU3MOUal0kkRjbQp8aB91nAdeAYDEj0fMyvhGmv0raI/J1lqSJoIdEuI4Z/ WKS1ysjkBehptsEkfhsBdzIf5BPIVA2/zrCEAXK+it4iN0ex5OjdxZoU2MfINNNip+b6 tI6IhBCULbWABwdnsPMzxTSXw7EGO+tyaFM1WqV1/TIaXfPYUSYDcM43o6iGwtB4fRrO 8+AQ== X-Gm-Message-State: AOAM531nFZ2eq0kNCbmXLFoCR7yPsPcCkNY7O7wcGJzTbugtryCfvadN /LFZjDCyBBdJcAqnRp9ms2w= X-Google-Smtp-Source: ABdhPJyGCcVU826RHHkW/QBdZ6r/MsN4F0wdJSbV7FA19XAFP1HUc+Rq8MpQnk2kKxg3ciJEek9I1w== X-Received: by 2002:a05:6402:6da:: with SMTP id n26mr26868699edy.203.1619024061980; Wed, 21 Apr 2021 09:54:21 -0700 (PDT) Received: from client-192-168-1-100.lan ([95.155.85.46]) by smtp.gmail.com with ESMTPSA id q6sm55200ejt.51.2021.04.21.09.54.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 21 Apr 2021 09:54:21 -0700 (PDT) Date: Wed, 21 Apr 2021 18:54:20 +0200 From: Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= To: Arnd Bergmann Cc: Bjorn Helgaas , Heiner Kallweit , Arnd Bergmann , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] PCI/VPD: fix unused pci_vpd_set_size function warning Message-ID: References: <20210421140334.3847155-1-arnd@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20210421140334.3847155-1-arnd@kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org Hi Arnd, > The only user of this function is now in an #ifdef, causing > a warning when that symbol is not defined: > > drivers/pci/vpd.c:289:13: error: 'pci_vpd_set_size' defined but not used [-Werror=unused-function] > 289 | static void pci_vpd_set_size(struct pci_dev *dev, size_t len) > > Move the function into that #ifdef block. [...] Thank you! Reviewed-by: Krzysztof Wilczyński Krzysztof