From: Christoph Hellwig <hch@infradead.org>
To: Heiner Kallweit <hkallweit1@gmail.com>
Cc: Christoph Hellwig <hch@infradead.org>,
Bjorn Helgaas <bhelgaas@google.com>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
Bjorn Helgaas <helgaas@kernel.org>
Subject: Re: [PATCH v2] PCI/VPD: Use unaligned access helpers in pci_vpd_read
Date: Wed, 12 May 2021 08:21:51 +0100 [thread overview]
Message-ID: <YJuCD9WCpV+rViys@infradead.org> (raw)
In-Reply-To: <26a9b3ec-07dc-c474-25ad-d7082060d305@gmail.com>
On Mon, May 10, 2021 at 09:09:02AM +0200, Heiner Kallweit wrote:
> len can have any value 1 .. 4. Also the proposal doesn't consider
> the skip value.
So what about just keeping the code as-is then? The existing version
is much easier to read than the new one, has less branching and doesn't
use an obscure API thast should not generally be used in driver code.
next prev parent reply other threads:[~2021-05-12 7:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-07 22:29 [PATCH v2] PCI/VPD: Use unaligned access helpers in pci_vpd_read Heiner Kallweit
2021-05-10 6:36 ` Christoph Hellwig
2021-05-10 7:09 ` Heiner Kallweit
2021-05-12 7:21 ` Christoph Hellwig [this message]
2021-05-12 7:56 ` Heiner Kallweit
2021-05-12 17:35 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YJuCD9WCpV+rViys@infradead.org \
--to=hch@infradead.org \
--cc=bhelgaas@google.com \
--cc=helgaas@kernel.org \
--cc=hkallweit1@gmail.com \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox