From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EDFBBC07E96 for ; Thu, 15 Jul 2021 07:35:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B7DA9610CB for ; Thu, 15 Jul 2021 07:35:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234351AbhGOHhw (ORCPT ); Thu, 15 Jul 2021 03:37:52 -0400 Received: from smtp-out1.suse.de ([195.135.220.28]:49702 "EHLO smtp-out1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229620AbhGOHhw (ORCPT ); Thu, 15 Jul 2021 03:37:52 -0400 Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 30FC22278A; Thu, 15 Jul 2021 07:34:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1626334498; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=W8D9wkVQjCjpsTZI0LeYY1YMvGOjfr6Eirr0wGuU3zw=; b=APjYsBSzgmbv27H6ngdklOnm9sX810tgnWNVSpE3s+unB4aMNPcDpcvOGlmEiHo/xnNGMQ zHqMGpiKfxahJdarGVTSMzzuZ5Mno14SlVZBzIxWzIj5dZLHjykzt6z2uVeiAJ0imSm3GT /OKEyKp9e/6m+n19R8VOa9w1vzg4ij8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1626334498; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=W8D9wkVQjCjpsTZI0LeYY1YMvGOjfr6Eirr0wGuU3zw=; b=j2sex9s0TGkB2tMcV8yUueddvu5574zDPkwrO+mqwSFNEYFpeaXk1dPvZEm49EyIY+DJOS qzgb5Rk+EfrwCGCA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id D1CFA13C2C; Thu, 15 Jul 2021 07:34:57 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id T82EMSHl72APZgAAMHmgww (envelope-from ); Thu, 15 Jul 2021 07:34:57 +0000 Date: Thu, 15 Jul 2021 09:34:55 +0200 From: Joerg Roedel To: "Rafael J. Wysocki" Cc: Joerg Roedel , Bjorn Helgaas , "Rafael J . Wysocki" , Len Brown , Linux PCI , ACPI Devel Maling List , Linux Kernel Mailing List Subject: Re: [PATCH v2 1/2] PCI/APCI: Move acpi_pci_osc_support() check to negotiation phase Message-ID: References: <20210714085512.2176-1-joro@8bytes.org> <20210714085512.2176-2-joro@8bytes.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org Hi Rafael, On Wed, Jul 14, 2021 at 02:04:17PM +0200, Rafael J. Wysocki wrote: > > decode_osc_support(root, "OS supports", support); > > - status = acpi_pci_osc_support(root, support); > > - if (ACPI_FAILURE(status)) { > > - *no_aspm = 1; > > > > - /* _OSC is optional for PCI host bridges */ > > - if ((status == AE_NOT_FOUND) && !is_pcie) > > + if (!pcie_ports_disabled) { > > If pcie_ports_disabled is set, we don't want to request any control > from the platform firmware at all and, specifically, we don't want to > evaluate _OSC with the OSC_QUERY_ENABLE clear in > capbuf[OSC_QUERY_DWORD]. > > I'm not sure how this is achieved after your changes. Yeah, it isn't. The acpi_pci_osc_control_set() function will always do an _OSC call with OSC_QUERY_ENABLE clear. I will come up with a new approach. Thanks, Joerg