From: Christoph Hellwig <hch@infradead.org>
To: Hans de Goede <hdegoede@redhat.com>
Cc: "Christoph Hellwig" <hch@infradead.org>,
"Rafael J . Wysocki" <rjw@rjwysocki.net>,
"Mika Westerberg" <mika.westerberg@linux.intel.com>,
"Krzysztof Wilczyński" <kw@linux.com>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Myron Stowe" <myron.stowe@redhat.com>,
"Juha-Pekka Heikkila" <juhapekka.heikkila@gmail.com>,
"Thomas Gleixner" <tglx@linutronix.de>,
"Ingo Molnar" <mingo@redhat.com>,
"Borislav Petkov" <bp@alien8.de>,
"H . Peter Anvin" <hpa@zytor.com>,
linux-acpi@vger.kernel.org, linux-pci@vger.kernel.org,
x86@kernel.org, linux-kernel@vger.kernel.org,
"Benoit Grégoire" <benoitg@coeus.ca>,
"Hui Wang" <hui.wang@canonical.com>
Subject: Re: [PATCH v3] x86/PCI: Ignore E820 reservations for bridge windows on newer systems
Date: Thu, 14 Oct 2021 08:16:42 -0700 [thread overview]
Message-ID: <YWhJ2kmGzNMVY+cP@infradead.org> (raw)
In-Reply-To: <40549939-e4c2-7b20-6bb6-0b5a46731b1c@redhat.com>
On Thu, Oct 14, 2021 at 05:15:02PM +0200, Hans de Goede wrote:
> Hi,
>
> On 10/14/21 3:40 PM, Christoph Hellwig wrote:
> > On Thu, Oct 14, 2021 at 01:03:57PM +0200, Hans de Goede wrote:
> >> + * Some BIOS-es contain a bug where they add addresses which map to system
> >> + * RAM in the PCI bridge memory window returned by the ACPI _CRS method,
> >
> > Please avoid the overly long lines in your comments.
>
> ?
>
> These lines are easily within the new 100 char line-length-limit ?
That is an exceptional limit if exceeding 80 improves readability for
individual lines.
> And checkpatch also does not complain about this.
checkpatch has been completely broken for a while and should not be
relied on in any way.
next prev parent reply other threads:[~2021-10-14 15:16 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-14 11:03 [PATCH v3] x86/PCI: Ignore E820 reservations for bridge windows on newer systems Hans de Goede
2021-10-14 11:14 ` Rafael J. Wysocki
2021-10-14 11:24 ` Hans de Goede
2021-10-14 12:06 ` Rafael J. Wysocki
2021-10-14 14:21 ` Hans de Goede
2021-10-14 14:53 ` Rafael J. Wysocki
2021-10-14 13:40 ` Christoph Hellwig
2021-10-14 15:15 ` Hans de Goede
2021-10-14 15:16 ` Christoph Hellwig [this message]
2021-10-14 15:24 ` Hans de Goede
2021-10-14 15:49 ` Bjorn Helgaas
2021-10-14 17:06 ` Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YWhJ2kmGzNMVY+cP@infradead.org \
--to=hch@infradead.org \
--cc=benoitg@coeus.ca \
--cc=bhelgaas@google.com \
--cc=bp@alien8.de \
--cc=hdegoede@redhat.com \
--cc=hpa@zytor.com \
--cc=hui.wang@canonical.com \
--cc=juhapekka.heikkila@gmail.com \
--cc=kw@linux.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=mingo@redhat.com \
--cc=myron.stowe@redhat.com \
--cc=rjw@rjwysocki.net \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).