From: "Krzysztof Wilczyński" <kw@linux.com>
To: kelvin.cao@microchip.com
Cc: kurt.schwemmer@microsemi.com, logang@deltatee.com,
bhelgaas@google.com, linux-pci@vger.kernel.org,
linux-kernel@vger.kernel.org, kelvincao@outlook.com,
Jakub Kicinski <kuba@kernel.org>
Subject: Re: [PATCH v2 4/5] PCI/switchtec: Replace ENOTSUPP with EOPNOTSUPP
Date: Fri, 15 Oct 2021 03:55:32 +0200 [thread overview]
Message-ID: <YWjflHn2pVW4IRyM@rocinante> (raw)
In-Reply-To: <20211014141859.11444-5-kelvin.cao@microchip.com>
[+cc Jakub for visibility]
Hi,
> ENOTSUPP is not a SUSV4 error code, and the following checkpatch.pl
> warning will be given for new patches which still use ENOTSUPP.
>
> WARNING: ENOTSUPP is not a SUSV4 error code, prefer EOPNOTSUPP
>
> See the link below for the discussion.
>
> https://lore.kernel.org/netdev/20200511165319.2251678-1-kuba@kernel.org/
This makes me wonder whether we should fix other occurrences of ENOTSUPP we
have in the PCI tree, as per:
Index File Line Content
0 drivers/pci/msi.c 1304 * -ENOTSUPP otherwise
1 drivers/pci/msi.c 1316 return -ENOTSUPP;
2 drivers/pci/pcie/dpc.c 355 return -ENOTSUPP;
3 drivers/pci/setup-res.c 421 return -ENOTSUPP;
4 drivers/pci/setup-res.c 433 return -ENOTSUPP;
5 drivers/pci/pci.c 3600 * Returns -ENOTSUPP if resizable BARs are not supported at all.
6 drivers/pci/pci.c 3610 return -ENOTSUPP;
7 drivers/pci/switch/switchtec.c 330 return -ENOTSUPP; \
8 drivers/pci/switch/switchtec.c 616 return -ENOTSUPP;
9 drivers/pci/switch/switchtec.c 824 return -ENOTSUPP;
10 drivers/pci/switch/switchtec.c 1559 return -ENOTSUPP;
11 drivers/pci/controller/dwc/pcie-tegra194.c 2244 return -ENOTSUPP;
What do you think Bjorn? Jakub?
Krzysztof
next prev parent reply other threads:[~2021-10-15 1:55 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-14 14:18 [PATCH v2 0/5] Switchtec Fixes and Improvements kelvin.cao
2021-10-14 14:18 ` [PATCH v2 1/5] PCI/switchtec: Error out MRPC execution when MMIO reads fail kelvin.cao
2021-10-15 1:21 ` Krzysztof Wilczyński
2021-10-15 22:13 ` Kelvin.Cao
2021-10-14 14:18 ` [PATCH v2 2/5] PCI/switchtec: Fix a MRPC error status handling issue kelvin.cao
2021-10-14 14:18 ` [PATCH v2 3/5] PCI/switchtec: Update the way of getting management VEP instance ID kelvin.cao
2021-10-14 14:18 ` [PATCH v2 4/5] PCI/switchtec: Replace ENOTSUPP with EOPNOTSUPP kelvin.cao
2021-10-15 1:55 ` Krzysztof Wilczyński [this message]
2021-10-14 14:18 ` [PATCH v2 5/5] PCI/switchtec: Add check of event support kelvin.cao
2021-10-14 14:47 ` [PATCH v2 0/5] Switchtec Fixes and Improvements Bjorn Helgaas
2021-10-14 21:19 ` Kelvin.Cao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YWjflHn2pVW4IRyM@rocinante \
--to=kw@linux.com \
--cc=bhelgaas@google.com \
--cc=kelvin.cao@microchip.com \
--cc=kelvincao@outlook.com \
--cc=kuba@kernel.org \
--cc=kurt.schwemmer@microsemi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=logang@deltatee.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox