From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: "Krzysztof Wilczyński" <kw@linux.com>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 1/1] PCI: probe: Use pci_find_vsec_capability() when looking for TBT devices
Date: Mon, 15 Nov 2021 12:33:24 +0200 [thread overview]
Message-ID: <YZI3dJ59DxE0GWWv@smile.fi.intel.com> (raw)
In-Reply-To: <YZCDHxOwogxPpuWy@rocinante>
On Sun, Nov 14, 2021 at 04:31:43AM +0100, Krzysztof Wilczyński wrote:
> Hi Andy,
>
> Nice find! There might one more driver that leverages the vendor-specific
> capabilities that seems to be also open coding pci_find_vsec_capability(),
> as per:
> ...
> Do you think that it would be worthwhile to also update this other driver
> to use pci_find_vsec_capability() at the same time? I might be nice to rid
> of the other open coded implementation too.
You mean https://lore.kernel.org/linux-fpga/20211109154127.18455-1-andriy.shevchenko@linux.intel.com/T/#u?
It seems a bit hard to explain HW people how the Linux kernel development
process is working. (Yes, shame on me that I haven't compiled that one)
...
> > Currently the set_pcie_thunderbolt() opens code pci_find_vsec_capability().
>
> I would write it as "open codes" in the above.
Hmm... Is anybody among us a native speaker (me — no)? :-)
But if you think it's better like this I'll definitely change.
(I admit I'm lost in a morphological analysis of the above two
words)
...
> Reviewed-by: Krzysztof Wilczyński <kw@linux.com>
Thank you!
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2021-11-15 10:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-09 15:16 [PATCH v1 1/1] PCI: probe: Use pci_find_vsec_capability() when looking for TBT devices Andy Shevchenko
2021-11-14 3:31 ` Krzysztof Wilczyński
2021-11-15 10:33 ` Andy Shevchenko [this message]
2021-11-15 12:10 ` Krzysztof Wilczyński
2021-11-14 6:22 ` Lukas Wunner
2021-11-15 10:33 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YZI3dJ59DxE0GWWv@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=bhelgaas@google.com \
--cc=kw@linux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox