From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 281C0C433FE for ; Sun, 13 Mar 2022 17:08:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235081AbiCMRJn (ORCPT ); Sun, 13 Mar 2022 13:09:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46372 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235049AbiCMRJm (ORCPT ); Sun, 13 Mar 2022 13:09:42 -0400 Received: from mail-ot1-x331.google.com (mail-ot1-x331.google.com [IPv6:2607:f8b0:4864:20::331]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E1FEC124C3D for ; Sun, 13 Mar 2022 10:08:34 -0700 (PDT) Received: by mail-ot1-x331.google.com with SMTP id g6-20020a9d6486000000b005acf9a0b644so10166200otl.12 for ; Sun, 13 Mar 2022 10:08:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=wDQcvU3O9fegsU0DwY4l35rHZ7y0JZdDaFDAx9WQ1dU=; b=Q+Wbckw1wonK4yRmxurG1PH1PNHun6axBbji+9LuL+tHhKxPXlo7IrI2MOPawYlohb ra6peV+zwWrDVClFIyfp2NMwKnhhpz3dIFfqy4Z4ewRa984IIXy/EeOXIgehHMjmhwsh GhpIIGRgvXosftqW+pbxe8nS5OY0L+uSJwt/ldYCkkGp0qcNrA4E5pIMXBdUwjfnez08 TPFf1PPjKcxm/Tdb9AYhK+9Ij1arJXseL6Hxa4P0p0VWWJN7boRcRhrKIbwPEJMJicJK /HUbMRFljD9bOsfTJkx7XVzK+JHST/gO3TqBY/ZQxJO0UEnUER5Cyca1zfmj+YlSSGby dEvg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=wDQcvU3O9fegsU0DwY4l35rHZ7y0JZdDaFDAx9WQ1dU=; b=IB82T3EX3YH9eCxpkG2dM1bClNvOInYhYH6Eb6frMgTQht2g0hj1AhGGW+eqa3+Qxf UQL/xEJjkW0f5tz3hJvVptFAe9XbHv2/M8PR5DyFcrCKPsF/yKvYDW3Oisc3FxQghJ9e oQe9vQqRGXS8pXc92yVrP2DPb66U3t3lQmRy2u2G+F9uLt9LqqJkVtp4xl3kCIEevt9B ZVXAuOo+Jdxamu1KB8zEaXaMwQWiczKgBWPFU97up9A2C+Ykyjp8OCF2O7W6s6aL6l8b m4gh3JLW2HFWRitiDUwBKyIfAej0mv6dlrNhVnLQUgoLPAMTRKni9YNqERqF/lHGcUX5 V/TA== X-Gm-Message-State: AOAM533tgABPtuGDiQ1CoEybC0m9456IPbzRO2F7oZmt2wPAQH7YTho+ Yt/729Z96sT30Vfsty7qYKOp5Q== X-Google-Smtp-Source: ABdhPJzcwjyugEwV5BMAAsC7aKlOM3HeMr6tjC5lrbs1q5DYKLztpI8FpviNUWzfXtStO8dIira72Q== X-Received: by 2002:a05:6830:1548:b0:5b2:3046:5b9a with SMTP id l8-20020a056830154800b005b230465b9amr9368016otp.286.1647191314232; Sun, 13 Mar 2022 10:08:34 -0700 (PDT) Received: from builder.lan ([2600:1700:a0:3dc8:3697:f6ff:fe85:aac9]) by smtp.gmail.com with ESMTPSA id y16-20020a9d6350000000b005c9653ab377sm36166otk.17.2022.03.13.10.08.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 13 Mar 2022 10:08:33 -0700 (PDT) Date: Sun, 13 Mar 2022 12:08:32 -0500 From: Bjorn Andersson To: Dmitry Baryshkov Cc: Andy Gross , Stephen Boyd , Michael Turquette , Taniya Das , Lorenzo Pieralisi , Krzysztof Wilczy??ski , Bjorn Helgaas , Prasad Malisetty , linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-pci@vger.kernel.org Subject: Re: [RFC PATCH 2/5] clk: qcom: gcc-sm8450: use new clk_regmap_mux_safe_ops for PCIe pipe clocks Message-ID: References: <20220313000824.229405-1-dmitry.baryshkov@linaro.org> <20220313000824.229405-3-dmitry.baryshkov@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220313000824.229405-3-dmitry.baryshkov@linaro.org> Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On Sat 12 Mar 18:08 CST 2022, Dmitry Baryshkov wrote: > Use newly defined clk_regmap_mux_safe_ops for PCIe pipe clocks to let > the clock framework automatically park the clock when the clock is > switched off and restore the parent when the clock is switched on. > > Signed-off-by: Dmitry Baryshkov Reviewed-by: Bjorn Andersson > --- > drivers/clk/qcom/gcc-sm8450.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/drivers/clk/qcom/gcc-sm8450.c b/drivers/clk/qcom/gcc-sm8450.c > index 593a195467ff..a5323d20bc0d 100644 > --- a/drivers/clk/qcom/gcc-sm8450.c > +++ b/drivers/clk/qcom/gcc-sm8450.c > @@ -243,13 +243,14 @@ static struct clk_regmap_mux gcc_pcie_0_pipe_clk_src = { > .reg = 0x7b060, > .shift = 0, > .width = 2, > + .safe_src_index = 2, > .parent_map = gcc_parent_map_4, > .clkr = { > .hw.init = &(struct clk_init_data){ > .name = "gcc_pcie_0_pipe_clk_src", > .parent_data = gcc_parent_data_4, > .num_parents = ARRAY_SIZE(gcc_parent_data_4), > - .ops = &clk_regmap_mux_closest_ops, > + .ops = &clk_regmap_mux_safe_ops, > }, > }, > }; > @@ -273,13 +274,14 @@ static struct clk_regmap_mux gcc_pcie_1_pipe_clk_src = { > .reg = 0x9d064, > .shift = 0, > .width = 2, > + .safe_src_index = 2, > .parent_map = gcc_parent_map_6, > .clkr = { > .hw.init = &(struct clk_init_data){ > .name = "gcc_pcie_1_pipe_clk_src", > .parent_data = gcc_parent_data_6, > .num_parents = ARRAY_SIZE(gcc_parent_data_6), > - .ops = &clk_regmap_mux_closest_ops, > + .ops = &clk_regmap_mux_safe_ops, > }, > }, > }; > -- > 2.34.1 >