From: Christoph Hellwig <hch@infradead.org>
To: Wangseok Lee <wangseok.lee@samsung.com>
Cc: Christoph Hellwig <hch@infradead.org>,
Alexander Lobakin <alexandr.lobakin@intel.com>,
"jingoohan1@gmail.com" <jingoohan1@gmail.com>,
"gustavo.pimentel@synopsys.com" <gustavo.pimentel@synopsys.com>,
"lorenzo.pieralisi@arm.com" <lorenzo.pieralisi@arm.com>,
"robh@kernel.org" <robh@kernel.org>,
"kw@linux.com" <kw@linux.com>,
"bhelgaas@google.com" <bhelgaas@google.com>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
"jesper.nilsson@axis.com" <jesper.nilsson@axis.com>,
"vkoul@kernel.org" <vkoul@kernel.org>,
"kernel@axis.com" <kernel@axis.com>,
Moon-Ki Jun <moonki.jun@samsung.com>
Subject: Re: [PATCH] PCI: dwc: Modify the check about MSI DMA mask 32-bit
Date: Thu, 7 Apr 2022 22:39:20 -0700 [thread overview]
Message-ID: <Yk/KiGgj3/8Se525@infradead.org> (raw)
In-Reply-To: <20220408053246epcms2p73d79512797c778a320394fe12e07edc6@epcms2p7>
On Fri, Apr 08, 2022 at 02:32:46PM +0900, Wangseok Lee wrote:
> I would like to continue reviewing the pcie-designware-host.c patch below.
> https://lore.kernel.org/all/20220328023009epcms2p309a5dfc2ff29d0a9945f65799963193c@epcms2p3/
The only new comment that I have is that the existing code also looks
completely broken. Why did the DMA_ATTR_SKIP_CPU_SYNC magically appear
in commit 07940c369a6b ("PCI: dwc: Fix MSI page leakage in suspend/resume")
and what is is tƦying to do except for completely breaking non-coherent
plaforms?
next prev parent reply other threads:[~2022-04-08 5:39 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20220328023009epcms2p309a5dfc2ff29d0a9945f65799963193c@epcms2p3>
2022-03-28 2:30 ` [PATCH] PCI: dwc: Modify the check about MSI DMA mask 32-bit 이왕석
2022-03-28 14:32 ` Alexander Lobakin
[not found] ` <CGME20220328143454epcas2p27a340d09e9f4e74af1eaa44559e372a5@epcms2p8>
2022-03-30 3:52 ` 이왕석
2022-03-30 9:35 ` Alexander Lobakin
2022-03-30 15:45 ` Christoph Hellwig
[not found] ` <CGME20220328143454epcas2p27a340d09e9f4e74af1eaa44559e372a5@epcms2p4>
2022-04-08 2:34 ` Wangseok Lee
2022-04-08 5:06 ` Christoph Hellwig
[not found] ` <CGME20220328143454epcas2p27a340d09e9f4e74af1eaa44559e372a5@epcms2p7>
2022-03-31 5:34 ` 이왕석
2022-04-08 5:32 ` Wangseok Lee
2022-04-08 5:39 ` Christoph Hellwig [this message]
2022-04-08 15:47 ` Lorenzo Pieralisi
[not found] ` <CGME20220328143454epcas2p27a340d09e9f4e74af1eaa44559e372a5@epcms2p5>
2022-04-11 6:59 ` Wangseok Lee
2022-04-11 7:10 ` Christoph Hellwig
[not found] ` <CGME20220328143454epcas2p27a340d09e9f4e74af1eaa44559e372a5@epcms2p1>
2022-04-11 9:47 ` Wangseok Lee
2022-04-11 12:54 ` Christoph Hellwig
2022-04-13 11:54 ` Robin Murphy
2022-04-18 3:12 ` Wangseok Lee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yk/KiGgj3/8Se525@infradead.org \
--to=hch@infradead.org \
--cc=alexandr.lobakin@intel.com \
--cc=bhelgaas@google.com \
--cc=gustavo.pimentel@synopsys.com \
--cc=jesper.nilsson@axis.com \
--cc=jingoohan1@gmail.com \
--cc=kernel@axis.com \
--cc=kw@linux.com \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=moonki.jun@samsung.com \
--cc=robh@kernel.org \
--cc=vkoul@kernel.org \
--cc=wangseok.lee@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).