From: Johan Hovold <johan@kernel.org>
To: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Cc: "Andy Gross" <agross@kernel.org>,
"Bjorn Andersson" <bjorn.andersson@linaro.org>,
"Stephen Boyd" <swboyd@chromium.org>,
"Michael Turquette" <mturquette@baylibre.com>,
"Taniya Das" <tdas@codeaurora.org>,
"Lorenzo Pieralisi" <lorenzo.pieralisi@arm.com>,
"Krzysztof Wilczyński" <kw@linux.com>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Prasad Malisetty" <quic_pmaliset@quicinc.com>,
linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
linux-pci@vger.kernel.org
Subject: Re: [PATCH v3 0/6] PCI: qcom: rework pipe_clk/pipe_clk_src handling
Date: Thu, 21 Apr 2022 12:28:52 +0200 [thread overview]
Message-ID: <YmEx5JPcDucjDiho@hovoldconsulting.com> (raw)
In-Reply-To: <20220413233144.275926-1-dmitry.baryshkov@linaro.org>
On Thu, Apr 14, 2022 at 02:31:38AM +0300, Dmitry Baryshkov wrote:
> PCIe pipe clk (and some other clocks) must be parked to the "safe"
> source (bi_tcxo) when corresponding GDSC is turned off and on again.
> Currently this is handcoded in the PCIe driver by reparenting the
> gcc_pipe_N_clk_src clock.
>
> Instead of doing it manually, follow the approach used by
> clk_rcg2_shared_ops and implement this parking in the enable() and
> disable() clock operations for respective pipe clocks.
Please take a look at the alternative approach of moving the pipe clock
muxing into the PHY driver:
https://lore.kernel.org/all/20220421102041.17345-1-johan+linaro@kernel.org/
The implementation is more straight forward and I believe it is also
more conceptually sound as it ties the muxing to when the PHY is powered
on so that the GCC pipe clock always has a valid source.
Johan
next prev parent reply other threads:[~2022-04-21 10:29 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-13 23:31 [PATCH v3 0/6] PCI: qcom: rework pipe_clk/pipe_clk_src handling Dmitry Baryshkov
2022-04-13 23:31 ` [PATCH v3 1/6] clk: qcom: add two parent_map helpers Dmitry Baryshkov
2022-04-13 23:31 ` [PATCH v3 2/6] clk: qcom: regmap-mux: add pipe clk implementation Dmitry Baryshkov
2022-04-13 23:31 ` [PATCH v3 3/6] clk: qcom: gcc-sm8450: use new clk_regmap_mux_safe_ops for PCIe pipe clocks Dmitry Baryshkov
2022-04-13 23:31 ` [PATCH v3 4/6] clk: qcom: gcc-sc7280: " Dmitry Baryshkov
2022-04-13 23:31 ` [PATCH v3 5/6] PCI: qcom: Remove unnecessary pipe_clk handling Dmitry Baryshkov
2022-04-13 23:31 ` [PATCH v3 6/6] PCI: qcom: Drop manual pipe_clk_src handling Dmitry Baryshkov
2022-04-21 10:28 ` Johan Hovold [this message]
2022-04-21 11:37 ` [PATCH v3 0/6] PCI: qcom: rework pipe_clk/pipe_clk_src handling Dmitry Baryshkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YmEx5JPcDucjDiho@hovoldconsulting.com \
--to=johan@kernel.org \
--cc=agross@kernel.org \
--cc=bhelgaas@google.com \
--cc=bjorn.andersson@linaro.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=kw@linux.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=mturquette@baylibre.com \
--cc=quic_pmaliset@quicinc.com \
--cc=swboyd@chromium.org \
--cc=tdas@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).