* [PATCH] PCI/IOV: export pci_vf_drivers_autoprobe() symbol
@ 2022-08-05 8:56 Yang Wang
2022-08-06 8:14 ` Christoph Hellwig
0 siblings, 1 reply; 3+ messages in thread
From: Yang Wang @ 2022-08-05 8:56 UTC (permalink / raw)
To: linux-pci; +Cc: bhelgaas, Yang Wang
make pci_vf_drivers_autoprobe() as export symbol.
the external module have no way to control vf autoprobe flag
before pf driver call pci_enable_sriov().
Signed-off-by: Yang Wang <KevinYang.Wang@amd.com>
---
drivers/pci/iov.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/pci/iov.c b/drivers/pci/iov.c
index 952217572113..4d992424959a 100644
--- a/drivers/pci/iov.c
+++ b/drivers/pci/iov.c
@@ -1033,6 +1033,8 @@ void pci_vf_drivers_autoprobe(struct pci_dev *dev, bool auto_probe)
if (dev->is_physfn)
dev->sriov->drivers_autoprobe = auto_probe;
}
+EXPORT_SYMBOL_GPL(pci_vf_drivers_autoprobe);
+
/**
* pci_iov_bus_range - find bus range used by Virtual Function
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] PCI/IOV: export pci_vf_drivers_autoprobe() symbol
2022-08-05 8:56 [PATCH] PCI/IOV: export pci_vf_drivers_autoprobe() symbol Yang Wang
@ 2022-08-06 8:14 ` Christoph Hellwig
2022-08-16 13:12 ` Leon Romanovsky
0 siblings, 1 reply; 3+ messages in thread
From: Christoph Hellwig @ 2022-08-06 8:14 UTC (permalink / raw)
To: Yang Wang; +Cc: linux-pci, bhelgaas
On Fri, Aug 05, 2022 at 04:56:39PM +0800, Yang Wang wrote:
> make pci_vf_drivers_autoprobe() as export symbol.
>
> the external module have no way to control vf autoprobe flag
> before pf driver call pci_enable_sriov().
But this does not actually seem to be used by any potentially
modular driver.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] PCI/IOV: export pci_vf_drivers_autoprobe() symbol
2022-08-06 8:14 ` Christoph Hellwig
@ 2022-08-16 13:12 ` Leon Romanovsky
0 siblings, 0 replies; 3+ messages in thread
From: Leon Romanovsky @ 2022-08-16 13:12 UTC (permalink / raw)
To: Christoph Hellwig; +Cc: Yang Wang, linux-pci, bhelgaas
On Sat, Aug 06, 2022 at 01:14:07AM -0700, Christoph Hellwig wrote:
> On Fri, Aug 05, 2022 at 04:56:39PM +0800, Yang Wang wrote:
> > make pci_vf_drivers_autoprobe() as export symbol.
> >
> > the external module have no way to control vf autoprobe flag
> > before pf driver call pci_enable_sriov().
>
> But this does not actually seem to be used by any potentially
> modular driver.
In addition, It is layer violation to control that flag from the driver.
Thanks
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-08-16 13:12 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-08-05 8:56 [PATCH] PCI/IOV: export pci_vf_drivers_autoprobe() symbol Yang Wang
2022-08-06 8:14 ` Christoph Hellwig
2022-08-16 13:12 ` Leon Romanovsky
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).