From: "Krzysztof Wilczyński" <kw@linux.com>
To: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Cc: Jon Hunter <jonathanh@nvidia.com>,
Vidya Sagar <vidyas@nvidia.com>,
Bjorn Helgaas <helgaas@kernel.org>,
jingoohan1@gmail.com, gustavo.pimentel@synopsys.com,
lpieralisi@kernel.org, robh@kernel.org, bhelgaas@google.com,
treding@nvidia.com, linux-pci@vger.kernel.org,
linux-kernel@vger.kernel.org, kthota@nvidia.com,
mmaddireddy@nvidia.com, sagar.tv@gmail.com
Subject: Re: [PATCH V1] PCI: dwc: Use dev_info for PCIe link down event logging
Date: Wed, 14 Sep 2022 21:44:44 +0900 [thread overview]
Message-ID: <YyHMvBhWgbDtv6V2@rocinante> (raw)
In-Reply-To: <20220914114306.GG16459@workstation>
Hello,
[...]
> Anyway, I don't strongly object the change and leave it to the
> maintainers to decide.
Perhaps it makes sense to make this a dev_dbg() over dev_info(), especially
since it appears that this information is of more use to the developer (who
most likely has the suitable log level set anyway), and given that there is
no way to reliably detect a presence in a slot on some platforms, this
might otherwise, add to the other messages that normal users don't pay
attention to usually - if this is not to be treated as an error.
Krzysztof
next prev parent reply other threads:[~2022-09-14 12:44 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-13 10:12 [PATCH V1] PCI: dwc: Use dev_info for PCIe link down event logging Vidya Sagar
2022-09-13 16:51 ` Manivannan Sadhasivam
2022-09-13 17:00 ` Jon Hunter
2022-09-13 20:07 ` Bjorn Helgaas
2022-09-14 6:24 ` Manivannan Sadhasivam
2022-09-14 11:02 ` Vidya Sagar
2022-09-14 11:18 ` Manivannan Sadhasivam
2022-09-14 11:25 ` Jon Hunter
2022-09-14 11:43 ` Manivannan Sadhasivam
2022-09-14 11:52 ` Jon Hunter
2022-09-14 12:44 ` Krzysztof Wilczyński [this message]
2022-09-14 13:45 ` Manivannan Sadhasivam
2022-09-14 14:52 ` Krzysztof Wilczyński
2022-09-14 15:11 ` Jon Hunter
2022-09-15 14:16 ` Rob Herring
2022-09-15 14:52 ` Manivannan Sadhasivam
2022-09-26 10:29 ` Vidya Sagar
2022-10-03 11:25 ` Vidya Sagar
2022-10-04 12:53 ` Rob Herring
2022-10-10 6:02 ` Vidya Sagar
2022-10-26 18:06 ` Rob Herring
2022-10-27 9:39 ` Lorenzo Pieralisi
2022-10-27 11:03 ` Manivannan Sadhasivam
2022-09-14 6:12 ` Manivannan Sadhasivam
2022-09-15 10:44 ` Manivannan Sadhasivam
2022-10-18 6:21 ` Jon Hunter
2022-10-18 16:43 ` Bjorn Helgaas
2022-10-26 11:39 ` Jon Hunter
2022-10-26 12:33 ` Lorenzo Pieralisi
2022-10-27 9:55 ` Ben Dooks
2022-10-27 11:05 ` Manivannan Sadhasivam
2022-11-10 15:40 ` Lorenzo Pieralisi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YyHMvBhWgbDtv6V2@rocinante \
--to=kw@linux.com \
--cc=bhelgaas@google.com \
--cc=gustavo.pimentel@synopsys.com \
--cc=helgaas@kernel.org \
--cc=jingoohan1@gmail.com \
--cc=jonathanh@nvidia.com \
--cc=kthota@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=mmaddireddy@nvidia.com \
--cc=robh@kernel.org \
--cc=sagar.tv@gmail.com \
--cc=treding@nvidia.com \
--cc=vidyas@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox