From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f43.google.com (mail-ej1-f43.google.com [209.85.218.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6C12515624B for ; Mon, 31 Mar 2025 09:20:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743412832; cv=none; b=YXw5OHoYdgwoEeMzHabSgt6PK32FH/1VNfb/6Zdw2sT5A+sjUC8dpE4CVZIwZaoFLTRGRsK84+XSwaHSR+5UTODvk5g7HJ613uVwEVdRDwYv41vIWG5SevPmXGQ7m/i3FYUpF2a2enO5PtKSB5J5RHk1XSGZL8klClJVoU+v2tI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743412832; c=relaxed/simple; bh=FH4g3fvpXV3lHKpvSvhwmjnLhb7FANS7ey999xYBE4E=; h=From:Date:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=egS2O+yk5YEw1+fkZCoSahSCDroGQRcbPMUCeHzIXcePYw0f9FVTdKFwj47vV01n2zs0e4rxRNjWqGDBnMIdxqHqTaSYkGEhv3x2Y+EJbWj6EFugfo8JLZFV9tpBVb0dR0YYSoWTAjP4l8r1igNT6R30afpo5EhF23ASYeDoWg4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=KRiVozBi; arc=none smtp.client-ip=209.85.218.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="KRiVozBi" Received: by mail-ej1-f43.google.com with SMTP id a640c23a62f3a-ac2bfcd2a70so559287866b.0 for ; Mon, 31 Mar 2025 02:20:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1743412829; x=1744017629; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=vkzLnbFVOYDObQyUvRiCdFcMVyW9LHfEzzCWp7sSsRM=; b=KRiVozBiaD6Kw3Pe2tHxOX3+sF2WPnMfxe0qGzETpUM24tWd+QSYBSVGbtoOH+Lf/v +R3mO75sLVqqRD1xFpXQBHW4As8vEdAEylmTBrkzoqpnk1WNOkCUbSDImGqk3izW2ANz tpjuW/L7I/Objb1MWNXG7mK+GkgoscDi/8K8Kc4Wa2wT8y2qo8sBAeDxWPxXfQOgV9Y9 KB6/5qy/9zWilcUFunTXHLVUZZF7mkz6b8+Z8VRVXHyXiTxn5bWvs+3dkYKuZw5rltDU A0BfzLCeqaYRDnGdUiq7KSGZUsrjwJnRQGSyLmEcJ61kaI7wvFyb9YEnXfI9EgO+iyE2 sMfQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1743412829; x=1744017629; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=vkzLnbFVOYDObQyUvRiCdFcMVyW9LHfEzzCWp7sSsRM=; b=KROrZ2uGbqcae1BEazrIntZaeRyEeYJjNNZXRaM1VMFsQDroo1lAMcpKxh8Lnwl7vd u12kzJHDxXf2uFKo+lbbR7w4aTgIIwr6n8QiCgQRbxhBOGp7mfIKkrGjpQ0QE3ZAnpaa 2q6IROPIdDd0lyk7n2na18eXDhaGIMSUeSjb6HrAgDjUdN4+U+MddOKtiYttpmZhypwz acGQnabQa/J3UxzhVUOquCOc5jC6B7syY0pYGp8emELO9ZDzUzxkgx1UR/dSp+yZKiHR F0bmLE2BDBMEwzRHWtBaRylxuNRoNvt54IbWHOUJN7Kh3mpu85r1wiBclRWRhkrAnpGQ 0oOw== X-Forwarded-Encrypted: i=1; AJvYcCVSssNP57BpAKR1+3xsFXokZhO/g5SOkBVM3C1G1Z9DJXAYlQONUzu3x1+W9LxpVi7R+mgz9G1EUhE=@vger.kernel.org X-Gm-Message-State: AOJu0YznUl9LmlQuHC1zIhM/vL7wDszEY95QFMAKT0F5P2pqTuN34r2w nJMIGx6AOv3xIjAm2HWCNvhrK9KExgEn8yGTyF/wY7F6jXv2dJJCFFpH6GGOBjY= X-Gm-Gg: ASbGncs7VOsMHCSfO3aSsum+4OkT46apEx5C0ntsrz32SGwaxhDHLJ+JXK4e8sCgyWc D1zSCvRNQXYowOE/vH8W5I/53Wpeq3TLQYjfefL7diuyrK1RDD041cFrKkTNEO8YiyuSAZAJ1eb +cHcW5sqN35AIn5Fmb7fAlB878VUfajKMsFeCSXe7yutO+Vodic7EF3YrrVWG9qji2YKaHzOh7h JwmTmLG0OFGIHU8vYrKGc0W/AGNQ3pClryjmQu6o2gsM+vXcxbWblYw78nj0qhaaa8WzNbueRZc 3Z5stx5sc5rlylIBduYV7fYIratVLVlfDN3dMtwY0bLAZWU1fz8UNghr5+6JGEWN7Wuqr0oKYyF ebiQS3jQaMe3NNBHTEpYKJFY= X-Google-Smtp-Source: AGHT+IFw4ZQBM4RCOBDHsaOKEO0WJ/K/tqyXI3QtId7X55gIJKhmKgjgqUxtnj7DaAzH7tFUE8PTlQ== X-Received: by 2002:a17:907:8686:b0:ac3:ef11:8787 with SMTP id a640c23a62f3a-ac738b910e3mr830432866b.54.1743412828665; Mon, 31 Mar 2025 02:20:28 -0700 (PDT) Received: from localhost (host-87-5-222-245.retail.telecomitalia.it. [87.5.222.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ac7192f0c66sm591000666b.78.2025.03.31.02.20.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 31 Mar 2025 02:20:28 -0700 (PDT) From: Andrea della Porta X-Google-Original-From: Andrea della Porta Date: Mon, 31 Mar 2025 11:21:45 +0200 To: Krzysztof Wilczynski Cc: Andrea della Porta , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Florian Fainelli , Broadcom internal kernel review list , Lorenzo Pieralisi , Manivannan Sadhasivam , Bjorn Helgaas , Linus Walleij , Catalin Marinas , Will Deacon , Bartosz Golaszewski , Derek Kiernan , Dragan Cvetic , Arnd Bergmann , Greg Kroah-Hartman , Saravana Kannan , linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, linux-gpio@vger.kernel.org, Masahiro Yamada , Stefan Wahren , Herve Codina , Luca Ceresoli , Thomas Petazzoni , Andrew Lunn , Phil Elwell , Dave Stevenson , kernel-list@raspberrypi.com Subject: Re: [PATCH v8 08/13] misc: rp1: RaspberryPi RP1 misc driver Message-ID: References: <3fbc487bc0e4b855ffbee8ed62cfb6bf3b0592e8.1742418429.git.andrea.porta@suse.com> <20250323114945.GD1902347@rocinante> Precedence: bulk X-Mailing-List: linux-pci@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250323114945.GD1902347@rocinante> Hi Krzysztof, On 20:49 Sun 23 Mar , Krzysztof Wilczynski wrote: > Hello, > > Thank you for sending new version. Appreciated. > > > + case IRQ_TYPE_LEVEL_HIGH: > > + dev_dbg(&rp1->pdev->dev, "MSIX IACK EN for irq %u\n", hwirq); > > + msix_cfg_set(rp1, hwirq, MSIX_CFG_IACK_EN); > > + rp1->level_triggered_irq[hwirq] = true; > > [...] > > + if (!irq) { > > + dev_err(&pdev->dev, "Failed to create irq mapping\n"); > > + err = -EINVAL; > > + goto err_unregister_interrupts; > > + } > > A small nitpick: "IRQ" in both of the above. Not a blocker, though, so > feel free to ignore this feedback. Ack. Many thanks, Andrea > > Krzysztof