From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f46.google.com (mail-ej1-f46.google.com [209.85.218.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A76E773451 for ; Fri, 29 Nov 2024 18:17:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732904264; cv=none; b=dWL7SVY3KxTMdfML9gXjz4H0F531ApK8nbZqD3NmuDdIUbv/k9f071DnEuGvsPENEVIlfbEmL4Xzdwb55FJidtyDMeCgB/2KurG5JL+yGQgu9sGxkauyLZKkkbdXSdGu7fxJoX7zcoorAZGG3NkMxUF8iRM5CBlNDxWnXBcMCos= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732904264; c=relaxed/simple; bh=fN0bLk90ZCqU7t/VgLksSaWfjvLd7tuev8IlpU2KjsE=; h=From:Date:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=EvvGb2Nkg99uOPdBAcLSsSyPqmVWcC+j6tancVnL8SCNLTb0awgwxmWxc10bi+itnLztKO9oxSRQ6B9FS0PzTdfu1k8qll37RY80b81V5Iky79zBwrUQUSnhrFeZbbXROnc966NAP3D+62Tq7laynYoSVeaVg0IxwdTTymzOVPY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=SnQRzeNL; arc=none smtp.client-ip=209.85.218.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="SnQRzeNL" Received: by mail-ej1-f46.google.com with SMTP id a640c23a62f3a-aa52a5641f8so284558766b.3 for ; Fri, 29 Nov 2024 10:17:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1732904259; x=1733509059; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=/K5xGcTYHJ/8xAu9IkRPPHbt4WWLkz+NlJpLlbPrtJ8=; b=SnQRzeNLk5c7PEqfpHhgVBsmwKuQCsuV1f/0oERNlyJqz/K2rylASeCEgXxa60Pgcc ingVz5XZcah5FZXSfGj1/zDe/yy1YB/q+eZStOeMvUeG0eVNyTZVuacz1SbBxShKBhrB 6da0qBDYWpnWYwfk6kmc20th2IXKiXfhqDQnunlU2tcq/XxRy7KIPxQ730SudN+mAYJz ioIIzug23+X977rvz2y7R+JMJ96tozihtkpI6BBY2UW7Zq3JiJmcQn8nI+aR+7WYH9Uk nS3FBAogQJm0+f1tLMAyVOPtcImOrptr1UUfa82JCWIN8qoHQvMzbso32yD89Xlj4dta yg+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1732904259; x=1733509059; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=/K5xGcTYHJ/8xAu9IkRPPHbt4WWLkz+NlJpLlbPrtJ8=; b=LRwL6PLVGlpS0xxOScNxMSbhgfzXhJ1rubyMWxoVAg1NYjqin23xfPCWquSXhWE8rn oCLjf6+xyVUsMgrwsDzuMnPnn4rRO0tngqz2HjL6/ugmmfmUBFr5hVEod6e3m5l4NPYD eAijKOiAA9aueO/FdDUNqhwkfV+X99hzG3YqDdX1bApp54Iod+DLvzLJjPdsptf58QOV Ydk6evKGSqDPGISH4lrhWvDlOZDdvvLcAft8tAKssEyIGOqCrMOhovp3PJNe9w5tCsGe TX+Jpvw86fJtLu4bjyNaC1Y4efx29DXZOSlctZs3uaWzk1erGr2Vk6m+UVJOEbpCvcro tRxw== X-Forwarded-Encrypted: i=1; AJvYcCVBmYn/mPMBPf3piF4iSzjjclIjCkyus8txkPDxramok0fhyyJBNNLEwg1XP+eiX9LCpqXgHsXTwHw=@vger.kernel.org X-Gm-Message-State: AOJu0Yzj+aFLPEw0BN7bAwsf4iuRWHoxO8DKj0166cvpfdy0a83NVkYU q7U+k93EM+LQgdvsCvceSAkMD12Zl+xdkZ6OI4uzHw+yrh9LjiGxzMWhcShdXU0= X-Gm-Gg: ASbGnctFuzntS+zhKdkuxC8D35x+CdtxD5kYBOK8fL8o1b8tlPJok5+xngGhstW2t3W deBYSGANtVjT74gfxbcSWHR5c6CN+Cg/I50GsbUoQgCi68dVOqz8EMzVDcHZUCaCvNClrT9ETpZ C/1lxxbmd92qGW73MEb2gyQIqef3XVZHcFLWar28TVPaQ43la2uwTKrl3ScLnNy1Ck4gMX2MHQg XVNmizWpXlq/L2e5/qKJqBfMFkTvfYjpKkyyqFFcFDNmngtNCg/ZjSSXFD74VEABbQR8ftji3V8 SV3tWHt0JVjIUnIsTBcu X-Google-Smtp-Source: AGHT+IFoJJFPtLBuSMIqJyGFIVwrCuTOeFzAqiPp8piO0gnCMrA5ajUljudZL/pGS/GtLks+6yCgNQ== X-Received: by 2002:a17:906:2189:b0:aa5:391e:cadf with SMTP id a640c23a62f3a-aa58103cca7mr869419266b.42.1732904258959; Fri, 29 Nov 2024 10:17:38 -0800 (PST) Received: from localhost (host-79-49-220-127.retail.telecomitalia.it. [79.49.220.127]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-aa5998e64dcsm197279866b.95.2024.11.29.10.17.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 29 Nov 2024 10:17:38 -0800 (PST) From: Andrea della Porta X-Google-Original-From: Andrea della Porta Date: Fri, 29 Nov 2024 19:18:12 +0100 To: Greg Kroah-Hartman Cc: Andrea della Porta , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Florian Fainelli , Broadcom internal kernel review list , Lorenzo Pieralisi , Krzysztof Wilczynski , Manivannan Sadhasivam , Bjorn Helgaas , Linus Walleij , Catalin Marinas , Will Deacon , Bartosz Golaszewski , Derek Kiernan , Dragan Cvetic , Arnd Bergmann , Saravana Kannan , linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, linux-gpio@vger.kernel.org, Masahiro Yamada , Stefan Wahren , Herve Codina , Luca Ceresoli , Thomas Petazzoni , Andrew Lunn Subject: Re: [PATCH v4 08/10] misc: rp1: RaspberryPi RP1 misc driver Message-ID: References: <2024112535-viper-uncivil-3054@gregkh> Precedence: bulk X-Mailing-List: linux-pci@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2024112535-viper-uncivil-3054@gregkh> Hi Greg, On 14:46 Mon 25 Nov , Greg Kroah-Hartman wrote: > On Sun, Nov 24, 2024 at 11:51:45AM +0100, Andrea della Porta wrote: > > --- a/include/linux/pci_ids.h > > +++ b/include/linux/pci_ids.h > > @@ -2611,6 +2611,9 @@ > > #define PCI_VENDOR_ID_TEKRAM 0x1de1 > > #define PCI_DEVICE_ID_TEKRAM_DC290 0xdc29 > > > > +#define PCI_VENDOR_ID_RPI 0x1de4 > > +#define PCI_DEVICE_ID_RPI_RP1_C0 0x0001 > > As you only use these in one file, please read the top of this file for > why this isn't needed here, but rather should be back in that one > driver. The reason I've defined them in pci_ids.h is due to the fact that they are indeed used both by the driver (drivers/misc/rp1/rp1_pci.c) and in drivers/pci/quirks.c. Many thanks, Andrea > > thanks, > > greg k-h