Re: [PATCH v5 01/16] rust: pass module name to `Module::init`

Greg KH
2024-12-11T10:45:57Z

On Tue, Dec 10, 2024 at 11:46:28PM +0100, Danilo Krummrich wrote:
> In a subsequent patch we introduce the `Registration` abstraction used
> to register driver structures. Some subsystems require the module name on
> driver registration (e.g. PCI in __pci_register_driver()), hence pass
> the module name to `Module::init`.

Nit, we don't need the NAME of the PCI driver (well, we do like it, but
that's not the real thing), we want the pointer to the module structure
in the register_driver call.

Does this provide for that? I'm thinking it does, but it's not the
"name" that is the issue here.

thanks,

greg k-h