From: Christoph Hellwig <hch@infradead.org>
To: Shivasharan S <shivasharan.srikanteshwara@broadcom.com>
Cc: linux-pci@vger.kernel.org, bhelgaas@google.com,
manivannan.sadhasivam@linaro.org, logang@deltatee.com,
Jonathan.Cameron@huawei.com, linux-kernel@vger.kernel.org,
sumanesh.samanta@broadcom.com, sathya.prakash@broadcom.com,
sjeaugey@nvidia.com
Subject: Re: [PATCH v3 2/2] PCI/P2PDMA: Modify p2p_dma_distance to detect P2P links
Date: Wed, 11 Dec 2024 21:04:33 -0800 [thread overview]
Message-ID: <Z1pu4YCfk6OAPsIP@infradead.org> (raw)
In-Reply-To: <1733901468-14860-3-git-send-email-shivasharan.srikanteshwara@broadcom.com>
On Tue, Dec 10, 2024 at 11:17:48PM -0800, Shivasharan S wrote:
> Update the p2p_dma_distance() to determine inter-switch P2P links existing
> between two switches and use this to calculate the DMA distance between
> two devices. This requires enabling the PCIE_P2P_LINK config option in
> the kernel.
What the heck are "P2P links supposed to be. And why shoud Linux
support something non-standard like this?
NAK for these hacks to the core code unless you can get a vendor
indpendent spec for it.
prev parent reply other threads:[~2024-12-12 5:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-11 7:17 [PATCH v3 0/2] PCI/portdrv: Report inter switch P2P links through sysfs Shivasharan S
2024-12-11 7:17 ` [PATCH v3 1/2] PCI/portdrv: Enable reporting inter-switch P2P links Shivasharan S
2024-12-11 7:17 ` [PATCH v3 2/2] PCI/P2PDMA: Modify p2p_dma_distance to detect " Shivasharan S
2024-12-12 5:04 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z1pu4YCfk6OAPsIP@infradead.org \
--to=hch@infradead.org \
--cc=Jonathan.Cameron@huawei.com \
--cc=bhelgaas@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=logang@deltatee.com \
--cc=manivannan.sadhasivam@linaro.org \
--cc=sathya.prakash@broadcom.com \
--cc=shivasharan.srikanteshwara@broadcom.com \
--cc=sjeaugey@nvidia.com \
--cc=sumanesh.samanta@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox