Re: [PATCH] misc: pci_endpoint_test: Add consecutive BAR test

[Niklas Cassel <cassel@kernel.org>]

On Sun, Nov 24, 2024 at 08:09:22AM +0530, Manivannan Sadhasivam wrote:
> On Sat, Nov 16, 2024 at 04:20:45AM +0100, Niklas Cassel wrote:
> > Add a more advanced BAR test that writes all BARs in one go, and then reads
> > them back and verifies that the value matches the BAR number bitwise OR:ed
> > with offset, this allows us to verify:
> > -The BAR number was what we intended to read.
> > -The offset was what we intended to read.
> > 
> > This allows us to detect potential address translation issues on the EP.
> > 
> > Reading back the BAR directly after writing will not allow us to detect the
> > case where inbound address translation on the endpoint incorrectly causes
> > multiple BARs to be redirected to the same memory region (within the EP).
> > 
> > Signed-off-by: Niklas Cassel <cassel@kernel.org>
> 
> Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>

Thanks for the review!

Could this patch please be picked up?


Kind regards,
Niklas