From: Niklas Cassel <cassel@kernel.org>
To: "Krzysztof Wilczyński" <kw@linux.com>
Cc: Damien Le Moal <dlemoal@kernel.org>,
linux-nvme@lists.infradead.org, Christoph Hellwig <hch@lst.de>,
Keith Busch <kbusch@kernel.org>, Sagi Grimberg <sagi@grimberg.me>,
linux-pci@vger.kernel.org,
Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>,
Kishon Vijay Abraham I <kishon@kernel.org>,
Bjorn Helgaas <bhelgaas@google.com>,
Lorenzo Pieralisi <lpieralisi@kernel.org>,
Rick Wertenbroek <rick.wertenbroek@gmail.com>
Subject: Re: [PATCH v7 17/18] nvmet: New NVMe PCI endpoint function target driver
Date: Mon, 23 Dec 2024 10:31:07 +0100 [thread overview]
Message-ID: <Z2kt26T3SKrmrUXI@ryzen> (raw)
In-Reply-To: <20241220161945.GA1007198@rocinante>
On Sat, Dec 21, 2024 at 01:19:45AM +0900, Krzysztof Wilczyński wrote:
> > +config NVME_TARGET_PCI_EPF
> > + tristate "NVMe PCI Endpoint Function target support"
> > + depends on NVME_TARGET && PCI_ENDPOINT
> > + help
> > + This enables the NVMe PCI endpoint function target driver support,
> > + which allows creating a NVMe PCI controller using an endpoint mode
> > + capable PCI controller.
> > +
>
> Perhaps:
>
> This enables the NVMe PCI Endpoint Function target support, which allows
> for the creation of an NVMe PCI controller using an endpoint mode capable
> PCI Express controller.
I like your suggestion.
However, looking at drivers/nvme/target/Kconfig:
$ git grep "This enables" origin/master drivers/nvme
origin/master:drivers/nvme/target/Kconfig: This enables debugfs support to display the connected controllers
origin/master:drivers/nvme/target/Kconfig: This enables target side NVMe passthru controller support for the
origin/master:drivers/nvme/target/Kconfig: This enables the NVMe loopback device support, which can be useful
origin/master:drivers/nvme/target/Kconfig: This enables the NVMe RDMA target support, which allows exporting NVMe
origin/master:drivers/nvme/target/Kconfig: This enables the NVMe FC target support, which allows exporting NVMe
origin/master:drivers/nvme/target/Kconfig: This enables the NVMe FC loopback test support, which can be useful
origin/master:drivers/nvme/target/Kconfig: This enables the NVMe TCP target support, which allows exporting NVMe
origin/master:drivers/nvme/target/Kconfig: This enables support for NVMe over Fabrics In-band Authentication in
It seems to use both:
"This enables the NVMe ... support"
"This enables NVMe ... support"
In this case, I think it reads better if we use the latter.
In fact, in all these cases I think it reads better without the "the".
Perhaps add a clean up patch that drops the "the"?
Kind regards,
Niklas
next prev parent reply other threads:[~2024-12-23 9:31 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-20 9:50 [PATCH v7 00/18] NVMe PCI endpoint target driver Damien Le Moal
2024-12-20 9:50 ` [PATCH v7 01/18] nvme: Move opcode string helper functions declarations Damien Le Moal
2024-12-20 9:50 ` [PATCH v7 02/18] nvmet: Add vendor_id and subsys_vendor_id subsystem attributes Damien Le Moal
2024-12-20 9:50 ` [PATCH v7 03/18] nvmet: Export nvmet_update_cc() and nvmet_cc_xxx() helpers Damien Le Moal
2024-12-20 9:50 ` [PATCH v7 04/18] nvmet: Introduce nvmet_get_cmd_effects_admin() Damien Le Moal
2024-12-20 9:50 ` [PATCH v7 05/18] nvmet: Add drvdata field to struct nvmet_ctrl Damien Le Moal
2024-12-20 9:50 ` [PATCH v7 06/18] nvme: Add PCI transport type Damien Le Moal
2024-12-20 9:50 ` [PATCH v7 07/18] nvmet: Improve nvmet_alloc_ctrl() interface and implementation Damien Le Moal
2024-12-20 9:50 ` [PATCH v7 08/18] nvmet: Introduce nvmet_req_transfer_len() Damien Le Moal
2024-12-20 9:50 ` [PATCH v7 09/18] nvmet: Introduce nvmet_sq_create() and nvmet_cq_create() Damien Le Moal
2024-12-20 9:51 ` [PATCH v7 10/18] nvmet: Add support for I/O queue management admin commands Damien Le Moal
2024-12-20 9:51 ` [PATCH v7 11/18] nvmet: Do not require SGL for PCI target controller commands Damien Le Moal
2024-12-20 9:51 ` [PATCH v7 12/18] nvmet: Introduce get/set_feature controller operations Damien Le Moal
2024-12-20 9:51 ` [PATCH v7 13/18] nvmet: Implement host identifier set feature support Damien Le Moal
2024-12-20 9:51 ` [PATCH v7 14/18] nvmet: Implement interrupt coalescing " Damien Le Moal
2024-12-20 9:51 ` [PATCH v7 15/18] nvmet: Implement interrupt config " Damien Le Moal
2024-12-20 9:51 ` [PATCH v7 16/18] nvmet: Implement arbitration " Damien Le Moal
2024-12-20 9:51 ` [PATCH v7 17/18] nvmet: New NVMe PCI endpoint function target driver Damien Le Moal
2024-12-20 12:18 ` Manivannan Sadhasivam
2024-12-20 16:19 ` Krzysztof Wilczyński
2024-12-23 9:31 ` Niklas Cassel [this message]
2024-12-24 23:34 ` kernel test robot
2024-12-20 9:51 ` [PATCH v7 18/18] Documentation: Document the NVMe PCI endpoint " Damien Le Moal
2024-12-20 12:22 ` [PATCH v7 00/18] " Manivannan Sadhasivam
2024-12-20 12:26 ` Manivannan Sadhasivam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z2kt26T3SKrmrUXI@ryzen \
--to=cassel@kernel.org \
--cc=bhelgaas@google.com \
--cc=dlemoal@kernel.org \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=kishon@kernel.org \
--cc=kw@linux.com \
--cc=linux-nvme@lists.infradead.org \
--cc=linux-pci@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=rick.wertenbroek@gmail.com \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox