Re: [PATCH v6 08/10] misc: rp1: RaspberryPi RP1 misc driver

Andrea della Porta
2025-01-21T15:10:32Z

Hi Andrew,

On 15:53 Tue 21 Jan , Andrew Lunn wrote:
> > > Well where are those externs defined at? Shouldn't there be a .h file
> > > for them somewhere in the tree if they really are global?
> >
> > Those symbols are deined in drivers/misc/rp1/rp1-pci.dtbo.S (added by
> > this patchset) and created by cmd_wrap_S_dtb in scripts/Makefile.lib.
>
> Could cmd_wrap_S_dtb be extended to actually produce a header?

It will produce a header nonetheless, one which is needed by just one .c
file violating Greg's rule about having a header only if referenced by more
than one source and the symbol is truly global, IMHO.

Thanks,
Andrea

>
> But that might confuse static analysers?
>
> Andrew