From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1EA6F1DA100; Thu, 16 Jan 2025 09:36:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737020184; cv=none; b=iZVSqbZgJD3hlZ8aKshkBvyArFK6YXTbhzNMFexcX0sjxO6WeEkROTvXszrxtz7jwoNFGwL5a4PEbxTesSiME2A8t4TxlCAouwjtB6MeiixMT+G+LAE2sYxUL75ujyksS3EGVxCvSeew75Qsxs8s/Ygx8jDlhbsnMM8KsXUvdig= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737020184; c=relaxed/simple; bh=a+FLVsVCo1GMCAm4HbywVjxhRCk2M/b12r35JUQSci8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Qjc7Dp59vyHqiB21n0UPFFqDArG1kc5YWNcmKes0xL5ZYU59zqErYnKEdwkEbDcC2fAwO3A3q7Dmo98PEFzU3iZtndsBWL8zl6QDvHjGfRToMHD6rHAzoRCsDP9Uv9uVeXpc5sggAcM5METFUUN6tVuAAKy12G8pNILEnQsLXcs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=KZ7ZFBHe; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="KZ7ZFBHe" Received: by smtp.kernel.org (Postfix) with ESMTPSA id B4667C4CED6; Thu, 16 Jan 2025 09:36:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1737020183; bh=a+FLVsVCo1GMCAm4HbywVjxhRCk2M/b12r35JUQSci8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=KZ7ZFBHegudWaLb4GB1oBFOdUA+oGlpKrPCnWkhqfKt3BXhQkEz3jjWt22xiI/CP7 YjvIQ1BYTmk6JhU+bK0mu4BcSm1Xd/V0p/ueHJ5SXOALJnK8XJzph0DScLHnzbMzQp DAd0jbwQ9cApKuNqLp1mHRnDFnqKxEhMtjVOwC/CtunJUWHhOGzgYCSGU2SQ2HY8Rd o9xjLOwXB3NEKSuyoLOPqxwF195Z9rqsWMeFIkabl+h6nKSi9bXq2fC6jxA9zx69iI 7VMBFUt+hXGbkA8wXMU1J7ccALT7m3xE3CwvIKm11fFDHR+bxInfWYuTrooGONjb8P 5AXcoX2nzJr3w== Date: Thu, 16 Jan 2025 10:36:18 +0100 From: Niklas Cassel To: Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= Cc: Manivannan Sadhasivam , Hans Zhang <18255117159@163.com>, kishon@kernel.org, arnd@arndb.de, gregkh@linuxfoundation.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, rockswang7@gmail.com Subject: Re: [v11 2/2] misc: pci_endpoint_test: Fix overflow of bar_size Message-ID: References: <20250109094556.1724663-1-18255117159@163.com> <20250109094556.1724663-3-18255117159@163.com> <20250115165842.p7vo24zwjvej2tbc@thinkpad> <20250116020300.GE2111792@rocinante> Precedence: bulk X-Mailing-List: linux-pci@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20250116020300.GE2111792@rocinante> Hello Krzysztof, On Thu, Jan 16, 2025 at 11:03:00AM +0900, Krzysztof Wilczyński wrote: > Hello, > > > I intended to stay silent, but considering that Mani gave additional > > feedback: > > I am glad you didn't as feedback is always appreciated. :) > > > - The Suggested-by tag should be in patch 1/2, not 2/2 :) > > (Patch 2/2 was 100% you.) > > I moved the Suggested-by tag around the correct patch. > > Thank you! > > Krzysztof Since you have already applied this series, with my comment fixed up, could your perhaps add the following (or similar) to the commit message in patch 2/2: " By changing the type to resource_size_t, which is a typedef to phys_addr_t, which can be 64-bit in certain configurations (e.g. X86_PAE selects PHYS_ADDR_T_64BIT), even when the compiler is 32-bit. Thus, we also need to change the division to do_div(), to properly perform a 64-bit division when the compiler is 32-bit. " in order to address Mani's comment. Kind regards, Niklas