From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B82F021576D for ; Fri, 14 Feb 2025 09:18:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739524698; cv=none; b=mfMZkVvXpPsQ1kCxEFI9398cJK1rq1f2bgZAi7pJnE8Hfg/cUJgNpVh0FWcf4U/Nqjwi3itSCCDQpVgjKfEO2F2I3GX3OokOOjwIwDgUAZ718B3QsXppJEOnLyZ18T/ufePocKOwZ+Jj7dL9uCioO0+1jufFOWymKZLs0wi6zRE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739524698; c=relaxed/simple; bh=JSsNLIQ7zt+yvVfmT/tV86Me2WdXoiS1bzfBSGilYHY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=BUWnWZogmhZgNyKv5HWVeG9tZkZ7/DJpLrXqV7aMOXeRZOphlknK/kpSG98yh2S1rVJNPMQAB6ffDR3G0+jEIk5zGa9gLD2+BqemeWxNHVbo9PTWXkwNBYSNb8oFi/TL8DJFnmDTh4T4Q0NowVnNcRwdJpxg6V7zyEA7euZP+LI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=IN/xx1/a; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="IN/xx1/a" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1B2ECC4CED1; Fri, 14 Feb 2025 09:18:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1739524698; bh=JSsNLIQ7zt+yvVfmT/tV86Me2WdXoiS1bzfBSGilYHY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=IN/xx1/aNDMrmfxQ5XNI5zPO2ctHsGBrucQCWjH3Fd712dZdvkDWXypTuU3sv+cLh cGJPKYlVBublOoifCQ6TyJNfsuQWzCv/A0NiNc/Cy4oEANnX/KfJ9At71kifq6IXHH B8GLw4ioPb+4n1Kl1PDCaoQYUaSyjevyUtnK+CCltJyb0oT+sGBth1wADrraMjwCjW Cy97dezYQA8X0Wq8tgZRkfbdT9+9/pYCcxX+AAS2k35biSYD4IHHoaJi0d4+0gThxo UBWL9jmmjuw79Fcu7MQMsU0gg/2UJe16ZP+0vInPXLmYcxVUMe81gSrtMKBl1G1dax uEWib/d4OKPMw== Received: from johan by xi.lan with local (Exim 4.97.1) (envelope-from ) id 1tirq7-000000006Wj-11PT; Fri, 14 Feb 2025 10:18:27 +0100 Date: Fri, 14 Feb 2025 10:18:27 +0100 From: Johan Hovold To: Ajay Agarwal Cc: Manivannan Sadhasivam , Manivannan Sadhasivam , Lorenzo Pieralisi , Bjorn Helgaas , Jingoo Han , Johan Hovold , Jon Hunter , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Rob Herring , Manu Gautam , Doug Zobel , William McVicker , Serge Semin , Robin Murphy , linux-pci@vger.kernel.org, Joao.Pinto@synopsys.com Subject: Re: [PATCH v5] PCI: dwc: Wait for link up only if link is started Message-ID: References: <20240130122906.GE83288@thinkpad> <20240130183626.GE4218@thinkpad> <20240206171043.GE8333@thinkpad> <20240228172951.GB21858@thinkpad> <20240310135140.GF3390@thinkpad> Precedence: bulk X-Mailing-List: linux-pci@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Fri, Feb 14, 2025 at 02:45:03PM +0530, Ajay Agarwal wrote: > Restarting this discussion for skipping the 1 sec of wait time if a > certain platform does not necessarily wish or expect to bring the link > up during probe time. I discussed with William and we think that a > module parameter can be added which if true, would lead to the skipping > of the wait time. By default, this parameter would be false, thereby > ensuring that the current behaviour to wait for the link is maintained. > > Please let me know if this is worth exploring. No, module parameters are a thing of the past (except possibly in vendor kernels). The default behaviour should just work. Johan