From: Varadarajan Narayanan <quic_varada@quicinc.com>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: <bhelgaas@google.com>, <lpieralisi@kernel.org>, <kw@linux.com>,
<manivannan.sadhasivam@linaro.org>, <robh@kernel.org>,
<krzk+dt@kernel.org>, <conor+dt@kernel.org>, <vkoul@kernel.org>,
<kishon@kernel.org>, <andersson@kernel.org>,
<konradybcio@kernel.org>, <p.zabel@pengutronix.de>,
<dmitry.baryshkov@linaro.org>, <quic_nsekar@quicinc.com>,
<linux-arm-msm@vger.kernel.org>, <linux-pci@vger.kernel.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-phy@lists.infradead.org>,
Praveenkumar I <quic_ipkumar@quicinc.com>,
Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Subject: Re: [PATCH v9 6/7] arm64: dts: qcom: ipq5332: Add PCIe related nodes
Date: Wed, 5 Feb 2025 21:05:38 +0530 [thread overview]
Message-ID: <Z6OFSr2vrmPJTp4u@hu-varada-blr.qualcomm.com> (raw)
In-Reply-To: <85f54baa-7d3d-43c3-9944-8f5f3c3006da@kernel.org>
[-- Attachment #1: Type: text/plain, Size: 7612 bytes --]
On Wed, Feb 05, 2025 at 02:47:13PM +0100, Krzysztof Kozlowski wrote:
> On 05/02/2025 11:49, Varadarajan Narayanan wrote:
> > On Mon, Feb 03, 2025 at 05:30:32PM +0100, Krzysztof Kozlowski wrote:
> >> On 28/01/2025 07:27, Varadarajan Narayanan wrote:
> >>>
> >>> @@ -479,6 +519,230 @@ frame@b128000 {
> >>> status = "disabled";
> >>> };
> >>> };
> >>> +
> >>> + pcie1: pcie@18000000 {
> >>> + compatible = "qcom,pcie-ipq5332", "qcom,pcie-ipq9574";
> >>> + reg = <0x00088000 0x3000>,
> >>
> >> So as Konrad pointed out now, this was never tested. It's not we who
> >> should run tests for you. It's you.
> >
> > This was tested and it did not flag an error since it is having the order
> > specified in the bindings. qcom,pcie.yaml has 4 reg specifications. Two of
>
>
> Hm, then please paste results of dtbs_check W=1 testing. Here.
>
> I am 100% sure you have there warning and I don't understand your
> reluctance to run the tests even after pointing it out by two people.
I ran the tests. Not sure which portions to paste. Have attached the full
output just in case you are interested in some other detail. Please take a
look.
Thanks
Varada
$ grep ipq.*dtb dtbs-check.log
DTC [C] arch/arm64/boot/dts/qcom/ipq5018-rdp432-c2.dtb
DTC [C] arch/arm64/boot/dts/qcom/ipq5018-tplink-archer-ax55-v1.dtb
DTC [C] arch/arm64/boot/dts/qcom/ipq5332-rdp441.dtb
DTC [C] arch/arm64/boot/dts/qcom/ipq5332-rdp442.dtb
DTC [C] arch/arm64/boot/dts/qcom/ipq5332-rdp468.dtb
DTC [C] arch/arm64/boot/dts/qcom/ipq5332-rdp474.dtb
DTC [C] arch/arm64/boot/dts/qcom/ipq5424-rdp466.dtb
DTC [C] arch/arm64/boot/dts/qcom/ipq6018-cp01-c1.dtb
/local/mnt/workspace/varada/upstream/pci-v10/arch/arm64/boot/dts/qcom/ipq5018-rdp432-c2.dtb: usb@8af8800: interrupts: [[0, 62, 4]] is too short
/local/mnt/workspace/varada/upstream/pci-v10/arch/arm64/boot/dts/qcom/ipq5018-rdp432-c2.dtb: usb@8af8800: interrupt-names: ['hs_phy_irq'] is too short
/local/mnt/workspace/varada/upstream/pci-v10/arch/arm64/boot/dts/qcom/ipq5018-rdp432-c2.dtb: usb@8af8800: interrupts: [[0, 62, 4]] is too short
/local/mnt/workspace/varada/upstream/pci-v10/arch/arm64/boot/dts/qcom/ipq5018-rdp432-c2.dtb: usb@8af8800: interrupt-names:0: 'pwr_event' was expected
/local/mnt/workspace/varada/upstream/pci-v10/arch/arm64/boot/dts/qcom/ipq5018-rdp432-c2.dtb: usb@8af8800: interrupt-names: ['hs_phy_irq'] is too short
/local/mnt/workspace/varada/upstream/pci-v10/arch/arm64/boot/dts/qcom/ipq5018-tplink-archer-ax55-v1.dtb: usb@8af8800: interrupts: [[0, 62, 4]] is too short
/local/mnt/workspace/varada/upstream/pci-v10/arch/arm64/boot/dts/qcom/ipq5018-tplink-archer-ax55-v1.dtb: usb@8af8800: interrupt-names: ['hs_phy_irq'] is too short
/local/mnt/workspace/varada/upstream/pci-v10/arch/arm64/boot/dts/qcom/ipq6018-cp01-c1.dtb: qusb@59000: 'vdd-supply' is a required property
/local/mnt/workspace/varada/upstream/pci-v10/arch/arm64/boot/dts/qcom/ipq5018-tplink-archer-ax55-v1.dtb: usb@8af8800: interrupts: [[0, 62, 4]] is too short
/local/mnt/workspace/varada/upstream/pci-v10/arch/arm64/boot/dts/qcom/ipq5018-tplink-archer-ax55-v1.dtb: usb@8af8800: interrupt-names:0: 'pwr_event' was expected
/local/mnt/workspace/varada/upstream/pci-v10/arch/arm64/boot/dts/qcom/ipq5018-tplink-archer-ax55-v1.dtb: usb@8af8800: interrupt-names: ['hs_phy_irq'] is too short
/local/mnt/workspace/varada/upstream/pci-v10/arch/arm64/boot/dts/qcom/ipq6018-cp01-c1.dtb: qusb@59000: 'vdda-pll-supply' is a required property
/local/mnt/workspace/varada/upstream/pci-v10/arch/arm64/boot/dts/qcom/ipq6018-cp01-c1.dtb: qusb@59000: 'vdda-phy-dpdm-supply' is a required property
Check: arch/arm64/boot/dts/qcom/ipq5018-rdp432-c2.dtb
/local/mnt/workspace/varada/upstream/pci-v10/arch/arm64/boot/dts/qcom/ipq6018-cp01-c1.dtb: usb@70f8800: interrupt-names: ['pwr_event', 'qusb2_phy'] is too short
Check: arch/arm64/boot/dts/qcom/ipq5018-tplink-archer-ax55-v1.dtb
DTC [C] arch/arm64/boot/dts/qcom/ipq8074-hk01.dtb
Check: arch/arm64/boot/dts/qcom/ipq5424-rdp466.dtb
Check: arch/arm64/boot/dts/qcom/ipq5332-rdp442.dtb
DTC [C] arch/arm64/boot/dts/qcom/ipq8074-hk10-c1.dtb
Check: arch/arm64/boot/dts/qcom/ipq5332-rdp468.dtb
Check: arch/arm64/boot/dts/qcom/ipq5332-rdp441.dtb
DTC [C] arch/arm64/boot/dts/qcom/ipq8074-hk10-c2.dtb
Check: arch/arm64/boot/dts/qcom/ipq5332-rdp474.dtb
arch/arm64/boot/dts/qcom/ipq6018-cp01-c1.dtb: /soc@0/remoteproc@cd00000: failed to match any schema with compatible: ['qcom,ipq6018-wcss-pil']
DTC [C] arch/arm64/boot/dts/qcom/ipq9574-rdp418.dtb
DTC [C] arch/arm64/boot/dts/qcom/ipq9574-rdp433.dtb
DTC [C] arch/arm64/boot/dts/qcom/ipq9574-rdp449.dtb
DTC [C] arch/arm64/boot/dts/qcom/ipq9574-rdp453.dtb
Check: arch/arm64/boot/dts/qcom/ipq6018-cp01-c1.dtb
/local/mnt/workspace/varada/upstream/pci-v10/arch/arm64/boot/dts/qcom/ipq8074-hk01.dtb: phy@59000: 'vdd-supply' is a required property
/local/mnt/workspace/varada/upstream/pci-v10/arch/arm64/boot/dts/qcom/ipq8074-hk01.dtb: phy@59000: 'vdda-pll-supply' is a required property
/local/mnt/workspace/varada/upstream/pci-v10/arch/arm64/boot/dts/qcom/ipq8074-hk01.dtb: phy@59000: 'vdda-phy-dpdm-supply' is a required property
/local/mnt/workspace/varada/upstream/pci-v10/arch/arm64/boot/dts/qcom/ipq8074-hk01.dtb: phy@79000: 'vdd-supply' is a required property
/local/mnt/workspace/varada/upstream/pci-v10/arch/arm64/boot/dts/qcom/ipq8074-hk01.dtb: phy@79000: 'vdda-pll-supply' is a required property
/local/mnt/workspace/varada/upstream/pci-v10/arch/arm64/boot/dts/qcom/ipq8074-hk01.dtb: phy@79000: 'vdda-phy-dpdm-supply' is a required property
DTC [C] arch/arm64/boot/dts/qcom/ipq9574-rdp454.dtb
/local/mnt/workspace/varada/upstream/pci-v10/arch/arm64/boot/dts/qcom/ipq9574-rdp418.dtb: usb@8af8800: interrupt-names: ['pwr_event'] is too short
/local/mnt/workspace/varada/upstream/pci-v10/arch/arm64/boot/dts/qcom/ipq9574-rdp418.dtb: usb@8af8800: interrupts-extended: [[1, 0, 134, 4]] is too short
/local/mnt/workspace/varada/upstream/pci-v10/arch/arm64/boot/dts/qcom/ipq9574-rdp449.dtb: usb@8af8800: interrupt-names: ['pwr_event'] is too short
/local/mnt/workspace/varada/upstream/pci-v10/arch/arm64/boot/dts/qcom/ipq9574-rdp449.dtb: usb@8af8800: interrupts-extended: [[1, 0, 134, 4]] is too short
/local/mnt/workspace/varada/upstream/pci-v10/arch/arm64/boot/dts/qcom/ipq9574-rdp453.dtb: usb@8af8800: interrupt-names: ['pwr_event'] is too short
/local/mnt/workspace/varada/upstream/pci-v10/arch/arm64/boot/dts/qcom/ipq9574-rdp453.dtb: usb@8af8800: interrupts-extended: [[1, 0, 134, 4]] is too short
Check: arch/arm64/boot/dts/qcom/ipq8074-hk10-c1.dtb
Check: arch/arm64/boot/dts/qcom/ipq8074-hk01.dtb
/local/mnt/workspace/varada/upstream/pci-v10/arch/arm64/boot/dts/qcom/ipq9574-rdp433.dtb: usb@8af8800: interrupt-names: ['pwr_event'] is too short
/local/mnt/workspace/varada/upstream/pci-v10/arch/arm64/boot/dts/qcom/ipq9574-rdp433.dtb: usb@8af8800: interrupts-extended: [[1, 0, 134, 4]] is too short
Check: arch/arm64/boot/dts/qcom/ipq8074-hk10-c2.dtb
/local/mnt/workspace/varada/upstream/pci-v10/arch/arm64/boot/dts/qcom/ipq9574-rdp454.dtb: usb@8af8800: interrupt-names: ['pwr_event'] is too short
/local/mnt/workspace/varada/upstream/pci-v10/arch/arm64/boot/dts/qcom/ipq9574-rdp454.dtb: usb@8af8800: interrupts-extended: [[1, 0, 134, 4]] is too short
Check: arch/arm64/boot/dts/qcom/ipq9574-rdp418.dtb
Check: arch/arm64/boot/dts/qcom/ipq9574-rdp449.dtb
Check: arch/arm64/boot/dts/qcom/ipq9574-rdp453.dtb
Check: arch/arm64/boot/dts/qcom/ipq9574-rdp433.dtb
Check: arch/arm64/boot/dts/qcom/ipq9574-rdp454.dtb
[-- Attachment #2: dtbs-check.log.gz --]
[-- Type: application/gzip, Size: 75207 bytes --]
next prev parent reply other threads:[~2025-02-05 15:36 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-28 6:27 [PATCH v9 0/7] Add PCIe support for Qualcomm IPQ5332 Varadarajan Narayanan
2025-01-28 6:27 ` [PATCH v9 1/7] dt-bindings: phy: qcom,uniphy-pcie: Document PCIe uniphy Varadarajan Narayanan
2025-01-28 6:27 ` [PATCH v9 2/7] phy: qcom: Introduce PCIe UNIPHY 28LP driver Varadarajan Narayanan
2025-01-28 6:27 ` [PATCH v9 3/7] dt-bindings: PCI: qcom: Use sdx55 reg description for ipq9574 Varadarajan Narayanan
2025-02-03 16:44 ` Bjorn Helgaas
2025-01-28 6:27 ` [PATCH v9 4/7] arm64: dts: qcom: ipq9574: Reorder reg and reg-names Varadarajan Narayanan
2025-01-28 6:27 ` [PATCH v9 5/7] dt-bindings: PCI: qcom: Document the IPQ5332 PCIe controller Varadarajan Narayanan
2025-01-28 7:27 ` Krzysztof Kozlowski
2025-01-28 6:27 ` [PATCH v9 6/7] arm64: dts: qcom: ipq5332: Add PCIe related nodes Varadarajan Narayanan
2025-02-03 16:30 ` Krzysztof Kozlowski
2025-02-05 10:49 ` Varadarajan Narayanan
2025-02-05 13:47 ` Krzysztof Kozlowski
2025-02-05 15:35 ` Varadarajan Narayanan [this message]
2025-02-05 15:53 ` Krzysztof Kozlowski
2025-02-05 15:54 ` Krzysztof Kozlowski
2025-02-06 6:19 ` Varadarajan Narayanan
2025-02-06 7:37 ` Krzysztof Kozlowski
2025-01-28 6:27 ` [PATCH v9 7/7] arm64: dts: qcom: ipq5332-rdp441: Enable PCIe phys and controllers Varadarajan Narayanan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z6OFSr2vrmPJTp4u@hu-varada-blr.qualcomm.com \
--to=quic_varada@quicinc.com \
--cc=andersson@kernel.org \
--cc=bhelgaas@google.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=kishon@kernel.org \
--cc=konrad.dybcio@oss.qualcomm.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=kw@linux.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=lpieralisi@kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=p.zabel@pengutronix.de \
--cc=quic_ipkumar@quicinc.com \
--cc=quic_nsekar@quicinc.com \
--cc=robh@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox