From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f67.google.com (mail-ej1-f67.google.com [209.85.218.67]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 937C422259A for ; Mon, 10 Feb 2025 12:54:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.67 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739192045; cv=none; b=Cmn/0hmoaMvMiKCeOrdrcjwmJuy5wnBfCNBXaHQGAOkrU2G34+g3V429rxx5RuIVH42yxZqtKmB71pQsM7oDOi2ko6cjNShoEAdjn/9UzfzURCsSlp6eb6JMNqWhqTaTug8yna6TlV9D5Y1kGmoOeK6qozqPXVVGTHcg4kxkuI4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739192045; c=relaxed/simple; bh=7A6tQDHT8Gygs27nVXNQUFzlGL1/SnpgPWEJccOdUoo=; h=From:Date:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=jPE2xjek63X24Mr8IXwW0G2J01nGrCuXAsLpVGUTErkCxiAai3s7Z76aLtRfd/r1Zmq3PrslmHepzrrNgRp2IDdfTBnHjeXvedlq1rj0fPWHQQCfeORXfS+GJWO/dwzpWgpzT4uLZd2VUMaHCgXhi/7QBjJtBmEnxpggC5qya6Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=P3h0rmGS; arc=none smtp.client-ip=209.85.218.67 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="P3h0rmGS" Received: by mail-ej1-f67.google.com with SMTP id a640c23a62f3a-ab7cb1154abso89539166b.0 for ; Mon, 10 Feb 2025 04:54:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1739192041; x=1739796841; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=Rf85jElMNnrDZvKC7vVh5MfFio59DRgJHRcTUJEvgGI=; b=P3h0rmGSIzJypOlZkNcOiyOuXI9tPLb8MlACDEThOAmgaAuxTYNrH+YuKT7i7yUlJe 3GV7NlcMOfW4VBTuhIIPv267BuafGzPV1lho4qwXOY7/1CvHrjhg+v4v+hWTL5gKOmFA h6egxTBbEwr5mmM4yJvfrYuUDz+Z3ybIOY70fvMIfk+jM4yS+Jdvdmv+NH1DuGF/yn+B eK82cPFvWzpWNWbg57bM2nERXIMKbOa2lVAllWKClLUiUXvd+X/DNIhXSWpWVHk0PqNe U/x2tQfgAgNUvIFXKhvVwAhpjwIqKPTdBvxkdDss43zbnZMMlY77rzoTYBgTMANcMrkV wwzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739192041; x=1739796841; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Rf85jElMNnrDZvKC7vVh5MfFio59DRgJHRcTUJEvgGI=; b=bj/XVtvvJd+SDXU5ndU6XUE2a0HmWMgCvkt6pbzygjltpAC6wwfHs+PvPdfX+Fj7na uJkr+90kZx4lgh3QO9I1nIG2RvNo7OsLR/5EsBKFsusVgdm/EFL6Gq72x2/YRMplb0rJ HjChLp/psCxHtrroIKNDZP++YSBZBTCBTt8P98Zt4HEZDdrfhHFMgOct5D437HNXC18M 1FN7znmPIHSCaTHcA7T5knEW5Hsm+UHwTvZuaIJ9Ht7ik0uZ1Zbo76+3qPC6s6VtYPPZ +0AftY6Ft9NyoajIc6U26wSfculVjqeIlcMUo8vfQ8xvjFGpAQ5bY7Hvudx4+7BtbIJ4 v+jA== X-Forwarded-Encrypted: i=1; AJvYcCWw1p9EIFZOP2KIzVtkOJNMmqkOELa0C6h17Zx/mJ9YHMgNTC4N1IakrmulFwYTnbKvCdkYsRyOjbw=@vger.kernel.org X-Gm-Message-State: AOJu0Yy1Me25ZrM4EPPfQQ/+vi9ly00HKHo1DNX1VvxcoBm/Aw8cwBCs CJ9IvuhVFBHCsiqGwOc5rvAVnwX5h0idZK8YakdgnS0+Tw1Ovr4Gu+7D1DZZqBQ= X-Gm-Gg: ASbGncvh+IBIji9nhNpQtrvynaS/agduVa70agvx1g+ArBSNuc9cg97c+8ZSG19HL00 QQv9a4/X2634oU6kk9xciRGToqV9JSUjPLSruYRB97jQTlh3DW8GeyMChLqqpCfOkSSH/Ul1sK8 CpFAzPzCjwAhb5JTQ68LpQNHWLQXwe9+Cta0HsiCYI2iyvGY4tXAO9KAsL77/T3coJX2l5MJHJG fg9MJcm77hbVgLdpG/f1+3z2L+1LyiDzW+SfYKDZCnP3q0nTCRaLOZadXT5QB8x9V2GHNYWAMoD JA2yGRmIB36oJFDEF/jZdffvTKinLKhVW2Q71rqyxV8/esiUDGaCNzrSW+0= X-Google-Smtp-Source: AGHT+IExaOon2TXZW9Vep+azLuX3PC+zXsCFuFLx/CO8qnQeXU427WnR0bcNBj8GMhFUwVXVl5oCDw== X-Received: by 2002:a05:6402:5290:b0:5dc:6e27:e6e8 with SMTP id 4fb4d7f45d1cf-5de450706fcmr34849448a12.24.1739192040759; Mon, 10 Feb 2025 04:54:00 -0800 (PST) Received: from localhost (host-79-41-239-37.retail.telecomitalia.it. [79.41.239.37]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5de5a2fc79esm4970729a12.10.2025.02.10.04.53.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Feb 2025 04:54:00 -0800 (PST) From: Andrea della Porta X-Google-Original-From: Andrea della Porta Date: Mon, 10 Feb 2025 13:55:00 +0100 To: Stefan Wahren Cc: Andrea della Porta , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Florian Fainelli , Broadcom internal kernel review list , Lorenzo Pieralisi , Krzysztof Wilczynski , Manivannan Sadhasivam , Bjorn Helgaas , Linus Walleij , Catalin Marinas , Will Deacon , Bartosz Golaszewski , Derek Kiernan , Dragan Cvetic , Arnd Bergmann , Greg Kroah-Hartman , Saravana Kannan , linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, linux-gpio@vger.kernel.org, Masahiro Yamada , Herve Codina , Luca Ceresoli , Thomas Petazzoni , Andrew Lunn Subject: Re: [PATCH v7 11/11] arm64: defconfig: Enable OF_OVERLAY option Message-ID: References: <49da5d0cf961fef23a1622253825443eb51d660d.1738963156.git.andrea.porta@suse.com> Precedence: bulk X-Mailing-List: linux-pci@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Hi Stefan, On 14:42 Sat 08 Feb , Stefan Wahren wrote: > Hi Andrea, > > Am 07.02.25 um 22:31 schrieb Andrea della Porta: > > The RP1 driver uses the infrastructure enabled by OF_OVERLAY config > > option. Enable that option in defconfig in order to produce a kernel > > usable on RaspberryPi5 avoiding to enable it separately. > > > > Signed-off-by: Andrea della Porta > > --- > > This patch is *OPTIONAL* since I'm not sure if OF_OVERLAY is a desirable > > feature to have enabled by default. It would be advisable to have it included > > so that 'make defconfig' can produce a kernel config that will work out > > of the box on Rpi5, otherwise OF_OVERLAY has to be enabled separately. > I think this isn't a good approach to convince the arm64 maintainer. > This change is not really optional for the Raspberry Pi 5 and possible > users/testers/CI rely on a working default configuration. > > So my first suggestion would be to provide a scripts/bloat-o-meter > output (before/after). Based on this the maintainer can better decided. I agree with you. IIUC what you are proposing, the following metrics should help to decide. The defconfig kernel with CONFIG_OF_OVERLAY=y added (wrt to the defconfig one without that set) has: - same uncompressed kernel image size (due to ELF section alignment I guess) - ~7Kb bigger Image.gz - 3 new modules (all related to RP1, i.e.: clk-rp1, pinctrl-rp1 and rp1-pci) - 27 added symbols, of which 5 exported hoping this is enough to gather a rough idea of the impact. > > In case this change is still rejected, we still have the option of > something like this [1] I'm ready to go down this way should the previous numbers not be convincing enough. Many thanks, Andrea > > Best regards > > [1] - > https://patchwork.kernel.org/project/linux-kbuild/patch/20200203184820.4433-3-nsaenzjulienne@suse.de/