Linux PCI subsystem development
 help / color / mirror / Atom feed
From: Feng Tang <feng.tang@linux.alibaba.com>
To: Markus Elfring <Markus.Elfring@web.de>
Cc: linux-pci@vger.kernel.org, "Bjorn Helgaas" <bhelgaas@google.com>,
	"Guanghui Feng" <guanghuifeng@linux.alibaba.com>,
	"Liguang Zhang" <zhangliguang@linux.alibaba.com>,
	"Lukas Wunner" <lukas@wunner.de>,
	"Rafael J. Wysocki" <rafael@kernel.org>,
	"Sathyanarayanan Kuppuswamy"
	<sathyanarayanan.kuppuswamy@linux.intel.com>,
	LKML <linux-kernel@vger.kernel.org>,
	"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
	"Jonathan Cameron" <Jonathan.Cameron@huawei.com>
Subject: Re: [PATCH v2 1/2] PCI/portdrv: Add necessary wait for disabling hotplug events
Date: Wed, 19 Feb 2025 10:19:48 +0800	[thread overview]
Message-ID: <Z7U_xNsQ04_tcTgB@U-2FWC9VHC-2323.local> (raw)
In-Reply-To: <a7ebd733-3fdd-4163-8fd4-9f70ee40c6be@web.de>

Hi Markus,

On Tue, Feb 18, 2025 at 10:00:33AM +0100, Markus Elfring wrote:
> > There was problem reported by firmware developers that they received
> > 2 pcie link control commands in very short intervals on an ARM server,
> > which doesn't comply with pcie spec, and broke their state machine and
> > work flow. According to PCIe 6.1 spec, section 6.7.3.2, software needs
> 
> Would you like to use key words in consistent ways also in such a change description?

Will do. thanks

> 
> > to wait at least 1 second for the command-complete event, before
> > resending the cmd or …
> 
>                 command?

Yes.

> …
> > ---
> > Changlog:
> >
> >   since v1:
> …
> 
> Are cover letters generally desirable for patch series?

The 2 patches solve different issue, and not logically relevant. But
I'll try in next version.

Thanks,
Feng

> Regards,
> Markus

  reply	other threads:[~2025-02-19  2:19 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-18  3:48 [PATCH v2 1/2] PCI/portdrv: Add necessary wait for disabling hotplug events Feng Tang
2025-02-18  3:48 ` [PATCH v2 2/2] PCI: Disable PCIE hotplug interrupts early when msi is disabled Feng Tang
2025-02-18  9:00 ` [PATCH v2 1/2] PCI/portdrv: Add necessary wait for disabling hotplug events Markus Elfring
2025-02-19  2:19   ` Feng Tang [this message]
2025-02-18 18:58 ` Sathyanarayanan Kuppuswamy
2025-02-19  6:53   ` Feng Tang
2025-02-18 22:33 ` Bjorn Helgaas
2025-02-19  2:53   ` Feng Tang
2025-02-19 11:12     ` Feng Tang
2025-02-19  5:57 ` kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Z7U_xNsQ04_tcTgB@U-2FWC9VHC-2323.local \
    --to=feng.tang@linux.alibaba.com \
    --cc=Jonathan.Cameron@huawei.com \
    --cc=Markus.Elfring@web.de \
    --cc=bhelgaas@google.com \
    --cc=guanghuifeng@linux.alibaba.com \
    --cc=ilpo.jarvinen@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=lukas@wunner.de \
    --cc=rafael@kernel.org \
    --cc=sathyanarayanan.kuppuswamy@linux.intel.com \
    --cc=zhangliguang@linux.alibaba.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox