Re: [v5 1/4] PCI: Introduce generic capability search functions

[Lukas Wunner <lukas@wunner.de>]

On Sat, Mar 22, 2025 at 12:38:00AM +0800, Hans Zhang wrote:
> Existing controller drivers (e.g., DWC, custom out-of-tree drivers)
> duplicate logic for scanning PCI capability lists. This creates
> maintenance burdens and risks inconsistencies.
> 
> To resolve this:
> 
> Add pci_host_bridge_find_*capability() in drivers/pci/pci.c, accepting
> controller-specific read functions and device data as parameters.
[...]
>  drivers/pci/pci.c   | 86 +++++++++++++++++++++++++++++++++++++++++++++

Please put this in a .c file which is only compiled and linked if
one of the controller drivers using those new helpers is enabled
in .config.

If you put the helpers in drivers/pci/pci.c, they unnecessarily
enlarge the kernel's .text section even if it's known already
at compile time that they're never going to be used (e.g. on x86).

You could put them in drivers/pci/controller/pci-host-common.c
and then select PCI_HOST_COMMON for each driver using them.
Or put them in a separate completely new file.


>  include/linux/pci.h | 16 ++++++++-

Helpers that are only used internally in the PCI core should be
declared in drivers/pci/pci.h.  I'd assume this also applies to
helpers used by controller drivers.

Thanks,

Lukas