linux-pci.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: Marcin Juszkiewicz <marcin.juszkiewicz@linaro.org>,
	linux-pci@vger.kernel.org, Minghuan Lian <minghuan.Lian@nxp.com>,
	Mingkai Hu <mingkai.hu@nxp.com>, Roy Zang <roy.zang@nxp.com>,
	linux-arm-kernel@lists.infradead.org,
	Jon Nettleton <jon@solid-run.com>,
	Keith Busch <kbusch@kernel.org>, Jens Axboe <axboe@fb.com>,
	Christoph Hellwig <hch@lst.de>, Sagi Grimberg <sagi@grimberg.me>,
	linux-nvme@lists.infradead.org
Subject: Re: Samsung PM991 NVME does not work on LX2160A system (Solidrun Honeycomb)
Date: Wed, 22 Mar 2023 21:16:20 -0700	[thread overview]
Message-ID: <ZBvSlHfXcX+oII5q@infradead.org> (raw)
In-Reply-To: <20230320161100.GA2292748@bhelgaas>

On Mon, Mar 20, 2023 at 11:11:00AM -0500, Bjorn Helgaas wrote:
> > The problem is that I am unable to use Samsung PM991 NVME there.
> > It is 2242 card so probably also DRAMless. Kernel says:
> > 
> > nvme 0004:01:00.0: Adding to iommu group 4
> > nvme nvme0: pci function 0004:01:00.0
> > nvme nvme0: missing or invalid SUBNQN field.
> > nvme nvme0: 1/0/0 default/read/poll queues
> > nvme 0004:01:00.0: VPD access failed.  This is likely a firmware bug on this device.  Contact the card vendor for a firmware update

I have no idea who even does the PCI vpd accesses here, but either
way there's not much we can do from the nvme driver side.

> > The SUBNQN part can be handled by adding quirk in nvme/core.c file
> > but that does not change situation. It also does not appear when
> > used in x86-64 system.

Although this suggests something is fishy with the config space
implementation for this particular hardware, and NVMe just happens
to trip it.

      reply	other threads:[~2023-03-23  4:16 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-20 11:58 Samsung PM991 NVME does not work on LX2160A system (Solidrun Honeycomb) Marcin Juszkiewicz
2023-03-20 16:11 ` Bjorn Helgaas
2023-03-23  4:16   ` Christoph Hellwig [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZBvSlHfXcX+oII5q@infradead.org \
    --to=hch@infradead.org \
    --cc=axboe@fb.com \
    --cc=hch@lst.de \
    --cc=helgaas@kernel.org \
    --cc=jon@solid-run.com \
    --cc=kbusch@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=marcin.juszkiewicz@linaro.org \
    --cc=minghuan.Lian@nxp.com \
    --cc=mingkai.hu@nxp.com \
    --cc=roy.zang@nxp.com \
    --cc=sagi@grimberg.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).