From: Johan Hovold <johan@kernel.org>
To: Rob Herring <robh@kernel.org>
Cc: "Lorenzo Pieralisi" <lpieralisi@kernel.org>,
"Krzysztof Wilczyński" <kw@linux.com>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
linux-pci@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: PCI: Fix unit address of example root port
Date: Tue, 11 Apr 2023 15:32:05 +0200 [thread overview]
Message-ID: <ZDVhVYZ838ksVMYP@hovoldconsulting.com> (raw)
In-Reply-To: <CAL_JsqJrhQA4dbU=bGioonqs6c=mZiGErcT9v9BxiGrNhmY6-w@mail.gmail.com>
On Wed, Apr 05, 2023 at 08:38:29AM -0500, Rob Herring wrote:
> On Wed, Apr 5, 2023 at 6:19 AM Johan Hovold <johan@kernel.org> wrote:
> >
> > On Fri, Mar 17, 2023 at 12:20:19PM +0100, Johan Hovold wrote:
> > > Fix the unit address of the example root port which is identical to the
> > > device number (i.e. 1).
> > >
> > > Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
> > > ---
> >
> > This one hasn't showed up in linux-next yet. Could you pick it up for
> > 6.4, Lorenzo?
>
> On 2nd thought, I think it's time to just remove this file. The schema
> is just missing some descriptions and 1 property (external-facing).
> I've added all that here[1].
Sounds good to me. Will you send a patch?
> I didn't add the example to the schema because the example here is
> incomplete and won't validate.
Fair enough. Having a decent example in the tree would be helpful, but
hopefully we can get the in-tree DT sources up to par at some point so
that they can serve that purpose.
Johan
> [1] https://github.com/robherring/dt-schema/commit/8445eb010e61496681e2504faf400e9fbc5b1acf
prev parent reply other threads:[~2023-04-11 13:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-17 11:20 [PATCH] dt-bindings: PCI: Fix unit address of example root port Johan Hovold
2023-03-21 20:18 ` Rob Herring
2023-04-05 11:19 ` Johan Hovold
2023-04-05 13:38 ` Rob Herring
2023-04-11 13:32 ` Johan Hovold [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZDVhVYZ838ksVMYP@hovoldconsulting.com \
--to=johan@kernel.org \
--cc=bhelgaas@google.com \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kw@linux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).