From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 416BBC7EE24 for ; Thu, 11 May 2023 21:50:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239232AbjEKVu6 (ORCPT ); Thu, 11 May 2023 17:50:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48260 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238053AbjEKVu5 (ORCPT ); Thu, 11 May 2023 17:50:57 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ACDBC5BB4; Thu, 11 May 2023 14:50:52 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 4A625651FF; Thu, 11 May 2023 21:50:52 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A4118C433EF; Thu, 11 May 2023 21:50:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1683841851; bh=K4WgEsYyO81HfMwY9MP7UqaYLOk4som61w9X0fncpTA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=D1Ma5etn8qiIyII92l350T7Kxgywc1UZMcdJDZ2SWzXv7qCxL0vkrwEik9Ckw0b3R y4RzWkniCey3x25t9y8sL53vQsyQOPgoZGp6qcUyM5RzCDeIh3JuuJAf260dmjuiRK 5ClqUIV2tXrig9u8DpnkR7LofOh5EleiEC+9GVo4dzp5MIdCJLMkGDePR4uKax8IZQ 6SyelbV1jhY8YtiB2Nl1zV6K057I6tPJlkCleXot1Z9gIwrC7nfnWqiOiVnYs8T4bP mTL9PAA3GFA2MeA04BmoIOiN6tcWVLmJCGQb8V+wIEDEFk/OD2FOUDoXes4W31fHgZ Op9Zwe0tIvwwg== Date: Thu, 11 May 2023 17:50:46 -0400 From: Sasha Levin To: "Limonciello, Mario" Cc: Thorsten Leemhuis , Linux regressions mailing list , Bjorn Helgaas , Hans de Goede , "S-k, Shyam-sundar" , "Goswami, Sanket" , "Gong, Richard" , Thomas Gleixner , Ingo Molnar , Dave Hansen , "x86@kernel.org" , "H. Peter Anvin" , "linux-kernel@vger.kernel.org" , "linux-pci@vger.kernel.org" , Borislav Petkov , Guenter Roeck , "stable@vger.kernel.org" Subject: Re: [PATCH 1/2] amd_nb: Add PCI ID for family 19h model 78h Message-ID: References: <20230427053338.16653-1-mario.limonciello@amd.com> <20230427053338.16653-2-mario.limonciello@amd.com> <7b74c389-97b7-4f56-851b-6ce17950a4d1@roeck-us.net> <084837c4-72c8-be92-fd1c-5ccbd805c559@leemhuis.info> <20230508112543.GBZFjcN2oxk4do31w4@fat_crate.local> <20230508134414.GCZFj8rieNwF1AOerB@fat_crate.local> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On Thu, May 11, 2023 at 07:51:42PM +0000, Limonciello, Mario wrote: >[AMD Official Use Only - General] > >+stable, Sasha > >> > Together with this patch there are now at least two regressions if >> > -rc1 whch could have been avoided and may impact testability on >> > affected systems. >> >> Are you saying that this patch which fixes s2idle on some random box >> should've gone to Linus *immediately*? >> >> And read my mail again: >> >> "Some fixes need longer testing because there have been cases where >> a fix breaks something else." >> >> So yes, I disagree with rushing fixes immediately. If they're obvious >> - whatever that means - then sure but not all of them are such. >> >> -- > >Unfortunately, it looks like the broken commit got backported into 6.1.28, >but the fix still isn't in Linus' tree. > >Sasha, > >Can you please pick up >https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git/commit/?h=x86/urgent&id=23a5b8bb022c1e071ca91b1a9c10f0ad6a0966e9 >for 6.1.29 to fix the regression? Happily, once it lands upstream :) -- Thanks, Sasha