From: Bjorn Helgaas <helgaas@kernel.org>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: "Wolfram Sang" <wsa+renesas@sang-engineering.com>,
linux-renesas-soc@vger.kernel.org,
"Marek Vasut" <marek.vasut+renesas@gmail.com>,
"Yoshihiro Shimoda" <yoshihiro.shimoda.uh@renesas.com>,
"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
"Krzysztof Wilczyński" <kw@linux.com>,
"Rob Herring" <robh@kernel.org>,
"Bjorn Helgaas" <bhelgaas@google.com>,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] PCI: rcar-host: add support for optional regulators
Date: Wed, 10 May 2023 16:18:04 -0500 [thread overview]
Message-ID: <ZFwKDDnWWDowYiIz@bhelgaas> (raw)
In-Reply-To: <CAMuHMdVHydQUBD6+zyLneuczd-3ixFbcF5z0toxZmhePT+ShSw@mail.gmail.com>
On Wed, May 10, 2023 at 09:27:46AM +0200, Geert Uytterhoeven wrote:
> On Wed, May 10, 2023 at 8:59 AM Wolfram Sang
> <wsa+renesas@sang-engineering.com> wrote:
> ...
> > static int rcar_pcie_probe(struct platform_device *pdev)
> > {
> > struct device *dev = &pdev->dev;
> > struct rcar_pcie_host *host;
> > struct rcar_pcie *pcie;
> > u32 data;
> > - int err;
> > + int i, err;
>
> unsigned int i?
>
> > struct pci_host_bridge *bridge;
>
> The (lack of) reverse-Xmas-tree ordering is hurting my OCD, but that's
> not your fault...
I usually put things in order of use, with initializations from
parameters first. Happily, that is often a pretty good approximation
of reverse-Xmas-tree, as it is here, so I'm all in favor of moving
"struct pci_host_bridge" up there :)
Bjorn
prev parent reply other threads:[~2023-05-10 21:18 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-10 6:58 [PATCH 0/2] KingFisher: support regulators for PCIe Wolfram Sang
2023-05-10 6:58 ` [PATCH 1/2] dt-bindings: PCI: rcar-pci-host: add optional regulators Wolfram Sang
2023-05-10 7:22 ` Geert Uytterhoeven
2023-05-10 7:56 ` Krzysztof Kozlowski
2023-05-10 6:58 ` [PATCH 2/2] PCI: rcar-host: add support for " Wolfram Sang
2023-05-10 7:27 ` Geert Uytterhoeven
2023-05-10 7:46 ` Wolfram Sang
2023-05-10 21:18 ` Bjorn Helgaas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZFwKDDnWWDowYiIz@bhelgaas \
--to=helgaas@kernel.org \
--cc=bhelgaas@google.com \
--cc=geert@linux-m68k.org \
--cc=kw@linux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=marek.vasut+renesas@gmail.com \
--cc=robh@kernel.org \
--cc=wsa+renesas@sang-engineering.com \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox