From: Bjorn Helgaas <helgaas@kernel.org>
To: Lukas Wunner <lukas@wunner.de>
Cc: Rongguang Wei <clementwei90@163.com>,
Rongguang Wei <weirongguang@kylinos.cn>,
linux-pci@vger.kernel.org, Bjorn Helgaas <bhelgaas@google.com>
Subject: Re: [PATCH] PCI: pciehp: Simplify Attention Button logging
Date: Wed, 24 May 2023 11:54:12 -0500 [thread overview]
Message-ID: <ZG5BNPlkacyGgWG6@bhelgaas> (raw)
In-Reply-To: <20230524100823.GA23020@wunner.de>
On Wed, May 24, 2023 at 12:08:23PM +0200, Lukas Wunner wrote:
> On Tue, May 23, 2023 at 10:40:39AM -0500, Bjorn Helgaas wrote:
> > I was trying to make it OFF/ON case parallel to the BLINKING case that
> > only has one ctrl_info(), but I think that makes it a little harder to
> > read in addition to being less efficient.
> >
> > And the language is definitely confusing. How about this?
>
> Perfect, feel free to add my
>
> Reviewed-by: Lukas Wunner <lukas@wunner.de>
>
> to commit 6d433b9ddfda on pci/hotplug.
Thanks, added!
prev parent reply other threads:[~2023-05-24 16:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-22 21:40 [PATCH] PCI: pciehp: Simplify Attention Button logging Bjorn Helgaas
2023-05-22 21:53 ` Bjorn Helgaas
2023-05-23 5:29 ` Lukas Wunner
2023-05-23 15:40 ` Bjorn Helgaas
2023-05-24 10:08 ` Lukas Wunner
2023-05-24 16:54 ` Bjorn Helgaas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZG5BNPlkacyGgWG6@bhelgaas \
--to=helgaas@kernel.org \
--cc=bhelgaas@google.com \
--cc=clementwei90@163.com \
--cc=linux-pci@vger.kernel.org \
--cc=lukas@wunner.de \
--cc=weirongguang@kylinos.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox