From: Bjorn Helgaas <helgaas@kernel.org>
To: Lukas Wunner <lukas@wunner.de>
Cc: Rongguang Wei <clementwei90@163.com>,
bhelgaas@google.com, linux-pci@vger.kernel.org,
Rongguang Wei <weirongguang@kylinos.cn>
Subject: Re: [PATCH v4] PCI: pciehp: Fix the slot in BLINKINGON_STATE when Presence Detect Changed event occurred
Date: Thu, 18 May 2023 06:09:41 -0500 [thread overview]
Message-ID: <ZGYHdbvZ8JJUFPMc@bhelgaas> (raw)
In-Reply-To: <20230518062557.GB13145@wunner.de>
On Thu, May 18, 2023 at 08:25:57AM +0200, Lukas Wunner wrote:
> On Wed, May 17, 2023 at 04:02:01PM -0500, Bjorn Helgaas wrote:
> > I'm curious why we want the 5 seconds of blinking power indicator at
> > all. We can't really do anything in response to an Attention Button
> > on an empty slot, so could we just ignore it completely in
> > pciehp_handle_button_press()?
>
> That wouldn't cover the case where the slot is occupied when the
> button is pressed, but the card is yanked out during the 5 second
> blinking interval.
Obviously we can't ignore a button press when the slot is occupied,
because that's part of the "insert card, press button to power it up"
and "press button to power down card, remove card" flows.
I'm asking about ignoring it when the slot is empty, which would mean
adding a check for card presence in pciehp_handle_button_press(). But
maybe there's a reason why we can't do that there?
Bjorn
next prev parent reply other threads:[~2023-05-18 11:11 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-12 2:15 [PATCH v4] PCI: pciehp: Fix the slot in BLINKINGON_STATE when Presence Detect Changed event occurred Rongguang Wei
2023-05-12 5:20 ` Lukas Wunner
2023-05-17 21:02 ` Bjorn Helgaas
2023-05-18 6:25 ` Lukas Wunner
2023-05-18 11:09 ` Bjorn Helgaas [this message]
2023-05-19 1:27 ` Rongguang Wei
2023-05-19 6:22 ` Lukas Wunner
2023-05-19 20:55 ` Bjorn Helgaas
2023-05-20 8:31 ` Lukas Wunner
2023-05-22 21:10 ` Bjorn Helgaas
2023-05-23 5:03 ` Lukas Wunner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZGYHdbvZ8JJUFPMc@bhelgaas \
--to=helgaas@kernel.org \
--cc=bhelgaas@google.com \
--cc=clementwei90@163.com \
--cc=linux-pci@vger.kernel.org \
--cc=lukas@wunner.de \
--cc=weirongguang@kylinos.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).