From: Bjorn Helgaas <helgaas@kernel.org>
To: Ajay Agarwal <ajayagarwal@google.com>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
Kuppuswamy Sathyanarayanan
<sathyanarayanan.kuppuswamy@linux.intel.com>,
Vidya Sagar <vidyas@nvidia.com>,
Nikhil Devshatwar <nikhilnd@google.com>,
Manu Gautam <manugautam@google.com>,
"David E. Box" <david.e.box@linux.intel.com>,
Kai-Heng Feng <kai.heng.feng@canonical.com>,
Michael Bottini <michael.a.bottini@linux.intel.com>,
linux-pci@vger.kernel.org
Subject: Re: [PATCH v3 0/5] PCI/ASPM: aspm_disable/default state handling and other trivial fixes
Date: Thu, 18 May 2023 16:54:10 -0500 [thread overview]
Message-ID: <ZGaegrNyjXSGe3kQ@bhelgaas> (raw)
In-Reply-To: <ZGadmGNsHhVO0e1P@bhelgaas>
On Thu, May 18, 2023 at 04:50:18PM -0500, Bjorn Helgaas wrote:
> On Thu, May 04, 2023 at 04:42:56PM +0530, Ajay Agarwal wrote:
> > On going through the aspm driver, I found some potential bugs
> > and opportunities for code cleanup in the way the aspm_disable
> > and aspm_default states are being handled by the driver.
> > Perform other refactoring as well.
> >
> > Changes from v2 to v3:
> > - Commit message updates
> >
> > Changes from v1 to v2:
> > - Split the patches into smaller patches
> > - Add the patch to rename L1.2 specific functions
> >
> > Ajay Agarwal (5):
> > PCI/ASPM: Disable ASPM_STATE_L1 only when driver disables L1 ASPM
> > PCI/ASPM: Set ASPM_STATE_L1 only when driver enables L1
> > PCI/ASPM: Set ASPM_STATE_L1 when driver enables L1ss
> > PCI/ASPM: Rename L1.2 specific functions
> > PCI/ASPM: Remove unnecessary ASPM_STATE_L1SS check
> >
> > drivers/pci/pcie/aspm.c | 34 +++++++++++++++-------------------
> > 1 file changed, 15 insertions(+), 19 deletions(-)
>
> Applied to pci/aspm for v6.5, thanks!
Forgot to mention that I picked up Sathy's Reviewed-by on patches 1
and 2 from the v2 posting. If you only change things suggested by the
reviewer, you can carry those tags forward to the next posting.
Bjorn
prev parent reply other threads:[~2023-05-18 21:54 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-04 11:12 [PATCH v3 0/5] PCI/ASPM: aspm_disable/default state handling and other trivial fixes Ajay Agarwal
2023-05-04 11:12 ` [PATCH v3 1/5] PCI/ASPM: Disable ASPM_STATE_L1 only when driver disables L1 ASPM Ajay Agarwal
2023-05-04 11:12 ` [PATCH v3 2/5] PCI/ASPM: Set ASPM_STATE_L1 only when driver enables L1 Ajay Agarwal
2023-05-04 11:12 ` [PATCH v3 3/5] PCI/ASPM: Set ASPM_STATE_L1 when driver enables L1ss Ajay Agarwal
2023-05-04 11:13 ` [PATCH v3 4/5] PCI/ASPM: Rename L1.2 specific functions Ajay Agarwal
2023-05-04 11:13 ` [PATCH v3 5/5] PCI/ASPM: Remove unnecessary ASPM_STATE_L1SS check Ajay Agarwal
2023-05-18 21:50 ` [PATCH v3 0/5] PCI/ASPM: aspm_disable/default state handling and other trivial fixes Bjorn Helgaas
2023-05-18 21:54 ` Bjorn Helgaas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZGaegrNyjXSGe3kQ@bhelgaas \
--to=helgaas@kernel.org \
--cc=ajayagarwal@google.com \
--cc=bhelgaas@google.com \
--cc=david.e.box@linux.intel.com \
--cc=kai.heng.feng@canonical.com \
--cc=linux-pci@vger.kernel.org \
--cc=manugautam@google.com \
--cc=michael.a.bottini@linux.intel.com \
--cc=nikhilnd@google.com \
--cc=sathyanarayanan.kuppuswamy@linux.intel.com \
--cc=vidyas@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox