From: Andi Shyti <andi.shyti@linux.intel.com>
To: Sui Jingfeng <15330273260@189.cn>
Cc: Sui Jingfeng <suijingfeng@loongson.cn>,
Andi Shyti <andi.shyti@linux.intel.com>,
Alex Deucher <alexander.deucher@amd.com>,
Christian Konig <christian.koenig@amd.com>,
Pan Xinhui <Xinhui.Pan@amd.com>, David Airlie <airlied@gmail.com>,
Daniel Vetter <daniel@ffwll.ch>,
Jani Nikula <jani.nikula@linux.intel.com>,
Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
Rodrigo Vivi <rodrigo.vivi@intel.com>,
Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>,
Ben Skeggs <bskeggs@redhat.com>,
Karol Herbst <kherbst@redhat.com>, Lyude Paul <lyude@redhat.com>,
Bjorn Helgaas <bhelgaas@google.com>,
Alex Williamson <alex.williamson@redhat.com>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
Hawking Zhang <Hawking.Zhang@amd.com>,
Mario Limonciello <mario.limonciello@amd.com>,
Lijo Lazar <lijo.lazar@amd.com>,
YiPeng Chai <YiPeng.Chai@amd.com>,
Andrey Grodzovsky <andrey.grodzovsky@amd.com>,
Somalapuram Amaranath <Amaranath.Somalapuram@amd.com>,
Bokun Zhang <Bokun.Zhang@amd.com>,
Ville Syrjala <ville.syrjala@linux.intel.com>,
Li Yi <liyi@loongson.cn>, Jason Gunthorpe <jgg@ziepe.ca>,
Kevin Tian <kevin.tian@intel.com>,
Cornelia Huck <cohuck@redhat.com>,
Yishai Hadas <yishaih@nvidia.com>,
Abhishek Sahu <abhsahu@nvidia.com>, Yi Liu <yi.l.liu@intel.com>,
kvm@vger.kernel.org, nouveau@lists.freedesktop.org,
intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org,
loongson-kernel@lists.loongnix.cn, amd-gfx@lists.freedesktop.org,
linux-pci@vger.kernel.org
Subject: Re: [Intel-gfx] [PATCH v2 1/2] vgaarb: various coding style and comments fix
Date: Tue, 6 Jun 2023 13:00:02 +0200 [thread overview]
Message-ID: <ZH8RslOfwIVf527x@ashyti-mobl2.lan> (raw)
In-Reply-To: <680cea2e-7984-5f26-c440-46047f4733fa@189.cn>
Hi Sui,
On Tue, Jun 06, 2023 at 06:27:05PM +0800, Sui Jingfeng wrote:
> Hi,
>
> On 2023/6/6 10:06, Sui Jingfeng wrote:
> > Originally, I also want to express the opinion.
>
>
> Originally, I want to express the same opinion as you told me.
>
> Because vga_iostate_to_str() function is taking unsigned int parameter.
>
> so, I think, using 'unsigned int *' type as the third parameter
> vga_str_to_iostate() function is more suitable.
>
>
> But this patch is too trivial, so I smash them into one patch.
it does not matter. Please keep patches separated. A trivial
patch can be ignored, however lots of trivial patches in a bigger
series might be appreciated.
Have fun!
Andi
next prev parent reply other threads:[~2023-06-06 11:05 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-04 20:58 [PATCH v2 1/2] vgaarb: various coding style and comments fix Sui Jingfeng
2023-06-04 20:58 ` [PATCH v2 2/2] vgaarb: introduce is_boot_device callback function to vga_client_register Sui Jingfeng
2023-06-05 22:16 ` [Intel-gfx] [PATCH v2 1/2] vgaarb: various coding style and comments fix Andi Shyti
2023-06-06 2:06 ` Sui Jingfeng
2023-06-06 10:27 ` Sui Jingfeng
2023-06-06 11:00 ` Andi Shyti [this message]
2023-06-06 19:49 ` Bjorn Helgaas
2023-06-07 6:16 ` Sui Jingfeng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZH8RslOfwIVf527x@ashyti-mobl2.lan \
--to=andi.shyti@linux.intel.com \
--cc=15330273260@189.cn \
--cc=Amaranath.Somalapuram@amd.com \
--cc=Bokun.Zhang@amd.com \
--cc=Hawking.Zhang@amd.com \
--cc=Xinhui.Pan@amd.com \
--cc=YiPeng.Chai@amd.com \
--cc=abhsahu@nvidia.com \
--cc=airlied@gmail.com \
--cc=alex.williamson@redhat.com \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=andrey.grodzovsky@amd.com \
--cc=bhelgaas@google.com \
--cc=bskeggs@redhat.com \
--cc=christian.koenig@amd.com \
--cc=cohuck@redhat.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
--cc=jgg@ziepe.ca \
--cc=joonas.lahtinen@linux.intel.com \
--cc=kevin.tian@intel.com \
--cc=kherbst@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=lijo.lazar@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=liyi@loongson.cn \
--cc=loongson-kernel@lists.loongnix.cn \
--cc=lyude@redhat.com \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mario.limonciello@amd.com \
--cc=mripard@kernel.org \
--cc=nouveau@lists.freedesktop.org \
--cc=rodrigo.vivi@intel.com \
--cc=suijingfeng@loongson.cn \
--cc=tvrtko.ursulin@linux.intel.com \
--cc=tzimmermann@suse.de \
--cc=ville.syrjala@linux.intel.com \
--cc=yi.l.liu@intel.com \
--cc=yishaih@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox