From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E5BAAC7EE2C for ; Wed, 31 May 2023 02:18:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233957AbjEaCSs (ORCPT ); Tue, 30 May 2023 22:18:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54068 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230494AbjEaCSo (ORCPT ); Tue, 30 May 2023 22:18:44 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E5B5B10E; Tue, 30 May 2023 19:18:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=AHO4M8sGie0OSLO/d8Ur4iCaRbtViVC/sruAnPnDQl8=; b=WFqPI8lzgzeJCE5VBFZricroLX VFVwpGjv7oZfxVGuYabP5XSgYrcC99JBwmMBYwEpRi+4MJEEbTG56BDO9yUIfE/qrADTFZeCslMRu dmHDK8HvHqzd6jptf2Qgnmu/t6fjtnCbxR3U+mS1QqAeiyWIkDumPeLkHT1DpFGU9UqLiJhFrFY4J WBRjWzRJhXxIw+K+QX4dy+m0GYlzLwHfTPwOTjWnjlHDMoCBLYaoFCrndkR3NhfSew0gAc8HGkSrO f9NTyXgLW8vAcPNrycVkq0TGk003xokLYfWfkWkFgyk36xuCMPBFI+OHX4qVbSPIaqIajw98yJJW2 3ILdNcZw==; Received: from mcgrof by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1q4BPr-00FmRc-04; Wed, 31 May 2023 02:18:23 +0000 Date: Tue, 30 May 2023 19:18:22 -0700 From: Luis Chamberlain To: Ira Weiny Cc: Davidlohr Bueso , LiuLele , dave.jiang@intel.com, Jonathan.Cameron@huawei.com, alison.schofield@intel.com, bhelgaas@google.com, bwidawsk@kernel.org, dan.j.williams@intel.com, helgaas@kernel.org, linux-acpi@vger.kernel.org, linux-cxl@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, rostedt@goodmis.org, vishal.l.verma@intel.com Subject: Re: CXL memory device not created correctly Message-ID: References: <646793cc665bf_1231462943c@iweiny-mobl.notmuch> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <646793cc665bf_1231462943c@iweiny-mobl.notmuch> Sender: Luis Chamberlain Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On Fri, May 19, 2023 at 08:20:44AM -0700, Ira Weiny wrote: > Davidlohr Bueso wrote: > > On Fri, 19 May 2023, LiuLele wrote: > > > > >In my testing CXL device /sys/bus/cxl/devices/mem0 not created, and the get error messages : > > > > > >``` > > >cxl_pci 0000:0d:00.0: Failed to get interrupt for event Info log > > >``` > > > > > >My test environment is a qemu CXL emulator with qemu v8.0.0, Linux kernel v6.3.0. > > >While with kernel 5.9.13, /sys/bus/cxl/devices/mem0 can be created. > > > > Yes, this can be annoying and would argue the probe should not error out. > > I had to double check. Events are mandatory on devices. On checking > again interrupt support is mandatory as well. So that is why I errored > out here. The failure essentially creates a user visible regression whereas booting an older kernel fixes it. It is not a friendly error message when testing kernels / upgrading / test environments. The only thing I can think of is if a new kconfig symbol is introduced so to make such cases a bit more clearer for now as things get settled. Otherwise for testing this creates a few cycles of just noise. And I'd imagine even a few developer hours. Luis