From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6F4E5EB64DD for ; Tue, 11 Jul 2023 13:33:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232050AbjGKNdg (ORCPT ); Tue, 11 Jul 2023 09:33:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50566 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229652AbjGKNdc (ORCPT ); Tue, 11 Jul 2023 09:33:32 -0400 Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E2237E6A; Tue, 11 Jul 2023 06:33:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1689082409; x=1720618409; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=3mWlwfyj0TpsA85OQqIB9DgXGmiMWUXRVcYEkhHKRnM=; b=AttkmzzchvUVHYMUdZYtzOmqx1YuR2ntQvD97XuKw1yjQO67EMMxbpY3 VRpGyXhbFqCFBNEgJpcKPcs0wG4gpD3VtMmiTKwZG1Em1QTovWkQM2bQV ztKt5NkepxJNNNZdu80L7qjiTRV/mZY3bBQYCpaCzuqfoiA+rKlAkmDq6 e0kftV/xmPfxJRiANGdMRXtTJrgGqIHYj5ySi2QrgYLNFLpkwLORpdUuO w48IQbs12qwA+HzYCiNQWmoycdip+jJWu7AzEabPjRSXW3BXt+WPacACw yKrQVfE4oQrZSxZlXWMRTrtNuYpMjJeHJ0tD42o5a06etuWMvYcuxKLfY w==; X-IronPort-AV: E=McAfee;i="6600,9927,10768"; a="368117447" X-IronPort-AV: E=Sophos;i="6.01,196,1684825200"; d="scan'208";a="368117447" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Jul 2023 06:33:10 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10768"; a="895172613" X-IronPort-AV: E=Sophos;i="6.01,196,1684825200"; d="scan'208";a="895172613" Received: from smile.fi.intel.com ([10.237.72.54]) by orsmga005.jf.intel.com with ESMTP; 11 Jul 2023 06:33:03 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1qJDUD-001rRp-0b; Tue, 11 Jul 2023 16:33:01 +0300 Date: Tue, 11 Jul 2023 16:33:00 +0300 From: Andy Shevchenko To: Amadeusz =?utf-8?B?U8WCYXdpxYRza2k=?= Cc: Bjorn Helgaas , Mark Brown , Takashi Iwai , alsa-devel@alsa-project.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, Cezary Rojewski , Pierre-Louis Bossart , Kai Vehmanen , Hans de Goede Subject: Re: [PATCH 02/13] PCI: Add Intel Audio DSP devices to pci_ids.h Message-ID: References: <20230711125726.3509391-1-amadeuszx.slawinski@linux.intel.com> <20230711125726.3509391-3-amadeuszx.slawinski@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230711125726.3509391-3-amadeuszx.slawinski@linux.intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On Tue, Jul 11, 2023 at 02:57:15PM +0200, Amadeusz Sławiński wrote: > Those IDs are mostly sprinkled between HDA, Skylake, SOF and avs drivers. > Almost every use contains additional comments to identify to which > platform those IDs refer to. Add those IDs to pci_ids.h header, so that > there is one place which defines those names. >From style looks good to me, but I think somebody from ASoC/sound needs to carefully check HDA/non-HDA/etc. Reviewed-by: Andy Shevchenko # for the Intel Tangier ID > Acked-by: Mark Brown > Acked-by: Bjorn Helgaas > Signed-off-by: Amadeusz Sławiński -- With Best Regards, Andy Shevchenko