From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D3064EB64DC for ; Tue, 11 Jul 2023 14:02:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233226AbjGKOCc (ORCPT ); Tue, 11 Jul 2023 10:02:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41576 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232798AbjGKOCb (ORCPT ); Tue, 11 Jul 2023 10:02:31 -0400 Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 27E229E; Tue, 11 Jul 2023 07:02:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1689084151; x=1720620151; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=akEEbdgIackI+bwcJjUC7oCu6EgQWkViNrk7VaPnBp4=; b=D7hfNuCdcNwDfVazU4Z8zAtFPMYB7BVwbhx8HFaBhmFqmdGYGhcBE3pL wrerP9R36yVq9EAhsYWA/hSLeJFJ+rXhGZOlA59aMHVANHSdCeLTwqNmc wWp7spD9rq4TvWrCPwF9Qpdubeva5Vv4UWuYp1ATqtDSPyuklBGrLbYB8 /o9/+J171OIJzD/f8lxz3sFeG9J7LI+VFJl6m24NeaJCRI8V+y+2GAwEV xBLQTt5tJ39e9AK4WKhP8P8z+sh7athpuK3mmYBQHsodoHnjaAVeSQUuJ yNa3r/st/WCVfe1B58F2HF7qWOn5YLVx5Ad2xOqshP/JjLFizxwPPRjRb w==; X-IronPort-AV: E=McAfee;i="6600,9927,10768"; a="344223042" X-IronPort-AV: E=Sophos;i="6.01,196,1684825200"; d="scan'208";a="344223042" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Jul 2023 07:02:30 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10768"; a="671381929" X-IronPort-AV: E=Sophos;i="6.01,196,1684825200"; d="scan'208";a="671381929" Received: from smile.fi.intel.com ([10.237.72.54]) by orsmga003.jf.intel.com with ESMTP; 11 Jul 2023 07:02:27 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1qJDwf-001rsM-2M; Tue, 11 Jul 2023 17:02:25 +0300 Date: Tue, 11 Jul 2023 17:02:25 +0300 From: Andy Shevchenko To: Amadeusz =?utf-8?B?U8WCYXdpxYRza2k=?= Cc: Bjorn Helgaas , Mark Brown , Takashi Iwai , alsa-devel@alsa-project.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, Cezary Rojewski , Pierre-Louis Bossart , Kai Vehmanen , Hans de Goede Subject: Re: [PATCH 09/13] ASoC: Intel: avs: Convert to PCI device IDs defines Message-ID: References: <20230711125726.3509391-1-amadeuszx.slawinski@linux.intel.com> <20230711125726.3509391-10-amadeuszx.slawinski@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230711125726.3509391-10-amadeuszx.slawinski@linux.intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On Tue, Jul 11, 2023 at 02:57:22PM +0200, Amadeusz Sławiński wrote: > Use PCI device IDs from pci_ids.h header and while at it change to using > PCI_DEVICE_DATA() macro, to simplify declarations. FWIW, Reviewed-by: Andy Shevchenko > Acked-by: Mark Brown > Signed-off-by: Amadeusz Sławiński > --- > sound/soc/intel/avs/core.c | 16 ++++++++-------- > 1 file changed, 8 insertions(+), 8 deletions(-) > > diff --git a/sound/soc/intel/avs/core.c b/sound/soc/intel/avs/core.c > index 637501850728..859b217fc761 100644 > --- a/sound/soc/intel/avs/core.c > +++ b/sound/soc/intel/avs/core.c > @@ -745,14 +745,14 @@ static const struct avs_spec apl_desc = { > }; > > static const struct pci_device_id avs_ids[] = { > - { PCI_VDEVICE(INTEL, 0x9d70), (unsigned long)&skl_desc }, /* SKL */ > - { PCI_VDEVICE(INTEL, 0xa170), (unsigned long)&skl_desc }, /* SKL-H */ > - { PCI_VDEVICE(INTEL, 0x9d71), (unsigned long)&skl_desc }, /* KBL */ > - { PCI_VDEVICE(INTEL, 0xa171), (unsigned long)&skl_desc }, /* KBL-H */ > - { PCI_VDEVICE(INTEL, 0xa2f0), (unsigned long)&skl_desc }, /* KBL-S */ > - { PCI_VDEVICE(INTEL, 0xa3f0), (unsigned long)&skl_desc }, /* CML-V */ > - { PCI_VDEVICE(INTEL, 0x5a98), (unsigned long)&apl_desc }, /* APL */ > - { PCI_VDEVICE(INTEL, 0x3198), (unsigned long)&apl_desc }, /* GML */ > + { PCI_DEVICE_DATA(INTEL, HDA_SKL_LP, &skl_desc) }, > + { PCI_DEVICE_DATA(INTEL, HDA_SKL, &skl_desc) }, > + { PCI_DEVICE_DATA(INTEL, HDA_KBL_LP, &skl_desc) }, > + { PCI_DEVICE_DATA(INTEL, HDA_KBL, &skl_desc) }, > + { PCI_DEVICE_DATA(INTEL, HDA_KBL_H, &skl_desc) }, > + { PCI_DEVICE_DATA(INTEL, HDA_CML_S, &skl_desc) }, > + { PCI_DEVICE_DATA(INTEL, HDA_APL, &apl_desc) }, > + { PCI_DEVICE_DATA(INTEL, HDA_GML, &apl_desc) }, > { 0 } > }; > MODULE_DEVICE_TABLE(pci, avs_ids); > -- > 2.34.1 > -- With Best Regards, Andy Shevchenko