From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 87DB1EB64DD for ; Wed, 12 Jul 2023 15:54:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233847AbjGLPy0 (ORCPT ); Wed, 12 Jul 2023 11:54:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34868 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233839AbjGLPyY (ORCPT ); Wed, 12 Jul 2023 11:54:24 -0400 Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DB0691FE3; Wed, 12 Jul 2023 08:54:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1689177261; x=1720713261; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=Ntin9ux60UydRjUjJN52xacdzkihb/yAwVR8rFD8U60=; b=Fg6pUJi4BuR4DpaTGx3vrbEgv8Jq6w+p4nFfXl/etNds/Ar5GK38Hjjq ANaA1IxOkgmXS7HUqKNS3Ns8U8F0Xk/SwiOLFbXOqGuJuFf2AkUHhVPKO WMuJLeL82lhkYpPUnQen1KDVnXIa1/LX3tNK040JE3iTAVbAdNsMpU5rn tVE9XO04yMT0pZY1tbbkKxA5MbKwGUvv1wp9cKjxjnxG9jWAjSwUO7AuV cSRoWjP6isXMGeTOe9NPhD0Udq8XrAG8ncTvhYW0DehiByAxqX+JpdEUy /ZitT3fEZKjqZrQ+ftrcQYDn/LAsqVyraUaOOTSXpIckx41L3MlpiP7pG g==; X-IronPort-AV: E=McAfee;i="6600,9927,10769"; a="395725079" X-IronPort-AV: E=Sophos;i="6.01,200,1684825200"; d="scan'208";a="395725079" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Jul 2023 08:54:21 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10769"; a="866174784" X-IronPort-AV: E=Sophos;i="6.01,200,1684825200"; d="scan'208";a="866174784" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga001.fm.intel.com with ESMTP; 12 Jul 2023 08:54:18 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1qJcAS-002AZo-2J; Wed, 12 Jul 2023 18:54:16 +0300 Date: Wed, 12 Jul 2023 18:54:16 +0300 From: Andy Shevchenko To: Amadeusz =?utf-8?B?U8WCYXdpxYRza2k=?= Cc: Bjorn Helgaas , Mark Brown , Takashi Iwai , alsa-devel@alsa-project.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, Cezary Rojewski , Pierre-Louis Bossart , Kai Vehmanen , Hans de Goede Subject: Re: [PATCH 13/13] ASoC: Intel: sst: Convert to PCI device IDs defines Message-ID: References: <20230711125726.3509391-1-amadeuszx.slawinski@linux.intel.com> <20230711125726.3509391-14-amadeuszx.slawinski@linux.intel.com> <958f3638-f68a-ebec-29cc-816f823b017f@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <958f3638-f68a-ebec-29cc-816f823b017f@linux.intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On Wed, Jul 12, 2023 at 02:19:47PM +0200, Amadeusz Sławiński wrote: > On 7/11/2023 4:33 PM, Andy Shevchenko wrote: > > On Tue, Jul 11, 2023 at 02:57:26PM +0200, Amadeusz Sławiński wrote: > > > Use PCI device IDs from pci_ids.h header. ... > > > switch (sst->dev_id) { > > > - case SST_MRFLD_PCI_ID: > > > + case PCI_DEVICE_ID_INTEL_ADSP_TNG: > > > case SST_BYT_ACPI_ID: > > > case SST_CHV_ACPI_ID: > > > > I think this needs a bit more, i.e. replacing the rest with respective PCI IDs. > > > > All three will be defined with SST prefix, which makes sense to me. > > > > ACPI here is a bit misleading, but correct. The ACPI specification assumes that > > respective part of the ID space covers 100% of PCI ID space. > > > > I have briefly checked the code and it seems that ID is used externally only > > for PCI case, so we may simply use the lower 16 bits of the ACPI _HID for the > > context. > > Do I understand correctly that I should just do: > #define PCI_DEVICE_ID_INTEL_SST_BYT 0x0F28 > #define PCI_DEVICE_ID_INTEL_SST_CHV 0x22A8 > and use those IDs instead? Correct! -- With Best Regards, Andy Shevchenko