From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 85E80C83F17 for ; Mon, 28 Aug 2023 09:20:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229931AbjH1JT3 (ORCPT ); Mon, 28 Aug 2023 05:19:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42006 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229850AbjH1JSz (ORCPT ); Mon, 28 Aug 2023 05:18:55 -0400 Received: from elvis.franken.de (elvis.franken.de [193.175.24.41]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 30031107; Mon, 28 Aug 2023 02:18:52 -0700 (PDT) Received: from uucp by elvis.franken.de with local-rmail (Exim 3.36 #1) id 1qaYOX-0004JP-00; Mon, 28 Aug 2023 11:18:49 +0200 Received: by alpha.franken.de (Postfix, from userid 1000) id 43C5BC01A3; Mon, 28 Aug 2023 11:10:59 +0200 (CEST) Date: Mon, 28 Aug 2023 11:10:59 +0200 From: Thomas Bogendoerfer To: Ilpo =?iso-8859-1?Q?J=E4rvinen?= Cc: linux-pci@vger.kernel.org, Bjorn Helgaas , Andi Shyti , Philippe =?iso-8859-1?Q?Mathieu-Daud=E9?= , linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 2/8] MIPS: TXx9: Do PCI error checks on own line Message-ID: References: <20230827133705.12991-1-ilpo.jarvinen@linux.intel.com> <20230827133705.12991-3-ilpo.jarvinen@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230827133705.12991-3-ilpo.jarvinen@linux.intel.com> Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On Sun, Aug 27, 2023 at 04:36:59PM +0300, Ilpo Järvinen wrote: > Instead of if conditions with line splits, use the usual error handling > pattern with a separate variable to improve readability. > > The second check can use reverse logic which reduces indentation level. > > No functional changes intended. > > Signed-off-by: Ilpo Järvinen > Reviewed-by: Philippe Mathieu-Daudé > --- > arch/mips/txx9/generic/pci.c | 43 +++++++++++++++++++----------------- > 1 file changed, 23 insertions(+), 20 deletions(-) applied to mips-next. Thomas. -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ]