Re: [PATCH] PCI: host-generic: Convert to platform remove callback returning void

[Philip Li <philip.li@intel.com>]

On Thu, Nov 23, 2023 at 09:25:35PM -0600, Bjorn Helgaas wrote:
> [+to lkp]
> 
> On Thu, Nov 23, 2023 at 06:12:36PM +0100, Uwe Kleine-König wrote:
> > On Mon, Nov 20, 2023 at 03:56:18PM -0600, Bjorn Helgaas wrote:
> > > From: Bjorn Helgaas <bhelgaas@google.com>
> > > On Fri, 20 Oct 2023 11:21:07 +0200, Uwe Kleine-König wrote:
> > > > The .remove() callback for a platform driver returns an int which makes
> > > > many driver authors wrongly assume it's possible to do error handling by
> > > > returning an error code.  However the value returned is (mostly) ignored
> > > > and this typically results in resource leaks. To improve here there is a
> > > > quest to make the remove callback return void. In the first step of this
> > > > quest all drivers are converted to .remove_new() which already returns
> > > > void.
> > > > 
> > > > [...]
> > > 
> > > Applied to "enumeration" for v6.8, thanks!
> > > 
> > > [1/1] PCI: host-generic: Convert to platform remove callback returning void
> > >       commit: d9dcdb4531fe39ce48919ef8c2c9369ee49f3ad2
> > 
> > Thanks! This branch isn't included in next. Is this on purpose?
> 
> To reduce the workload of the folks maintaining "next", I wait for the
> 0-day bot to build test a branch before merging it into the PCI "next"
> branch.
> 
> That usually takes a couple days after I push a branch to the
> kernel.org repo.  I have these branches that are currently waiting to
> be put into next:
> 
>   ecam            pushed 11/20     bot response 11/22
>   resource        pushed 11/20     no bot response yet
>   enumeration     pushed 11/20     no bot response yet
>   p2pdma          pushed 11/20     no bot response yet
>   switchtec       pushed 11/22     no bot response yet
> 
> Not sure if the 0-day bot is slower than usual right now, but I cc'd
> the LKP folks in case something is wrong.

Sorry about the recent slowness, Bjorn. This is our side problem, we met some
issues and the whole cluster can't achieve its usual utilization. We are still
working on resolving the issues, the report time would be delayed, though hard
to tell right now the accurate time.

We will check the status of these branches, if they are in low risk, we will
send our the current test status.

> 
> Bjorn
>